Date: Sat, 3 Nov 2007 22:05:03 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zvol.c Message-ID: <20071103210503.GH37519@garage.freebsd.pl> In-Reply-To: <472CDC0E.6000805@FreeBSD.org> References: <200711011104.lA1B4LeH036010@repoman.freebsd.org> <472CDC0E.6000805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--aT9PWwzfKXlsBJM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 03, 2007 at 09:37:34PM +0100, Kris Kennaway wrote: > Pawel Jakub Dawidek wrote: > >pjd 2007-11-01 11:04:21 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/contrib/opensolaris/uts/common/fs/zfs zvol.c=20 > > Log: > > Call zil_commit() (if ZIL is not disabled) after every non-read request > > (BIO_WRITE and BIO_FLUSH) as it is done is Solaris. The difference is > > that Solaris calls it only for sync requests, but we can't say in GEOM > > is the request is sync or async, so we do it for every request. > > =20 > > MFC after: 1 week > > =20 > > Revision Changes Path > > 1.4 +11 -11 src/sys/contrib/opensolaris/uts/common/fs/zfs/zvo= l.c > > > > >=20 > Does this add significant overhead? ZVOLs are replacement for disks and file system put on top of that should handle delaying write requests, etc. Even if there is overhead, this is the right thing to do, but I don't think it's significant. I'll do some tests a bit later, now I need to make ZFS compile again in my perforce after last integration:) --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --aT9PWwzfKXlsBJM1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHLOJ/ForvXbEpPzQRAkmhAJ0XJX0NCBN96fVhlrvCH7mOSe/hxQCg390v 6Y+tDUd0MN0biyViET/utFc= =BJg+ -----END PGP SIGNATURE----- --aT9PWwzfKXlsBJM1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071103210503.GH37519>