Date: Tue, 11 Sep 2001 02:00:00 +0200 From: Mark Santcroos <marks@ripe.net> To: Warner Losh <imp@harmony.village.org> Cc: current@FreeBSD.ORG Subject: Re: ToPIC100 not working correctly Message-ID: <20010911020000.A519@laptop.6bone.nl> In-Reply-To: <20010910215100.A578@laptop.6bone.nl>; from marks@ripe.net on Mon, Sep 10, 2001 at 09:51:00PM %2B0200 References: <86n14cms6f.wl@e-ppp8.eken.phys.nagoya-u.ac.jp> <200109031624.f83GOVh26528@harmony.village.org> <20010904112524.A542@laptop.6bone.nl> <20010905115107.D28669@enterprise.spock.org> <20010906135053.C464@laptop.6bone.nl> <20010910215100.A578@laptop.6bone.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 10, 2001 at 09:51:00PM +0200, Mark Santcroos wrote: > Do you know the exact reason for this problem or can I help by exactly > finding out what change of code causes this problems? I deciced to track it down. I narrowed it down to the commit to pcic_pci.c v1.71. For that version it had the following relevant change: 833,834c794,795 < DEVMETHOD(bus_setup_intr, pcic_pci_setup_intr), < DEVMETHOD(bus_teardown_intr, pcic_pci_teardown_intr), --- > DEVMETHOD(bus_setup_intr, bus_generic_setup_intr), > DEVMETHOD(bus_teardown_intr, bus_generic_teardown_intr), I translated that back to the -current code and it comes to the following 'workaround': diff /tmp/pccardd/current/pcic.c ./pcic.c 897c897 < return (bus_generic_teardown_intr(dev, child, irq, cookie)); --- > return 0; diff /tmp/pccardd/current/pcic_pci.c ./pcic_pci.c 1336c1336 < DEVMETHOD(bus_teardown_intr, bus_generic_teardown_intr), --- > DEVMETHOD(bus_teardown_intr, pcic_teardown_intr), IOW, just skip the bus_generic_teardown_intr(). I called it a workaround, cause I don't know if this is really a fix or a hack. (Don't know the code well enough for that) However, my problems disappeared with this patch. Please shine your light on this, or give a suggestion for a nice fix. Anyway, the fix seems close (and trivial). Thanks Mark -- Mark Santcroos RIPE Network Coordination Centre http://www.ripe.net/home/mark/ New Projects Group/TTM To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010911020000.A519>