Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Jun 1996 19:24:01 -0400 (EDT)
From:      Chuck Robey <chuckr@Glue.umd.edu>
To:        Satoshi Asami <asami@cs.berkeley.edu>
Cc:        dgy@rtd.com, freebsd-ports@freefall.freebsd.org
Subject:   Re: git problem
Message-ID:  <Pine.OSF.3.91.960616191718.4356B-100000@gilligan.eng.umd.edu>
In-Reply-To: <199606162307.QAA03189@silvia.HIP.Berkeley.EDU>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 16 Jun 1996, Satoshi Asami wrote:

>  * INSTALL instead of INSTALL_PROGRAM.  Our bsd.port.mk could (in this 
>  * light) be considered more correct than the configure script, I suppose.
> 
> Actually, I'm not exactly sure who's right here, I never understood
> that part of bsd.port.mk.... ;)
> 
> But anyway, it seems like the standard way ports deal with this is to
> set "STRIP=" and strip the binaries explicitly in the post-install
> target.

Doesn't work in this case, Satoshi.  The problem came up because the gnu 
software was stripping scripts, not because stuff wasn't getting 
stripped.  The author decided to fix this by modifying the 
INSTALL_PROGRAM value to not strip, and use it generally, and to make 
separate install-strip targets, using INSTALL_PROGRAM, that explicitly 
added the -s to install.  Our bsd.port.mk frustrated getting the -s off 
the INSTALL_PROGRAM, so everything was again getting stripped.

I put a patch in to change the Makefile.in's to use INSTALL, and not 
INSTALL_PROGRAM, to install scripts.  I think that's right, and now the 
install-strip targets work right, altho I don't use them, and binaries 
still get stripped.

I think the gnu author did it wrong, basically.  I have someone testing 
my new git (update) port on 2.1R, and I should be able to get it to you 
today.  I think our bsd.port.mk is right, altho I'm not sure it should be 
doing what it is (setting the INSTALL and INSTALL_PROGRAM values) is 
completely right, it's more correct than the configure script and gnu 
Makefiles.

> 
> Satoshi
> 

----------------------------+-----------------------------------------------
Chuck Robey                 | Interests include any kind of voice or data 
chuckr@eng.umd.edu          | communications topic, C programming, and Unix.
9120 Edmonston Ct #302      |
Greenbelt, MD 20770         | I run Journey2 and n3lxx, both FreeBSD
(301) 220-2114              | version 2.2 current -- and great FUN!
----------------------------+-----------------------------------------------




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.OSF.3.91.960616191718.4356B-100000>