Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Apr 2014 21:44:34 +0000 (UTC)
From:      Christian Brueffer <brueffer@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r264479 - head/sbin/savecore
Message-ID:  <201404142144.s3ELiYH5055042@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brueffer
Date: Mon Apr 14 21:44:34 2014
New Revision: 264479
URL: http://svnweb.freebsd.org/changeset/base/264479

Log:
  Fix double fclose() in an error case.
  
  CID:		1006120
  Found with:	Coverity Prevent(tm)
  MFC after:	1 week

Modified:
  head/sbin/savecore/savecore.c

Modified: head/sbin/savecore/savecore.c
==============================================================================
--- head/sbin/savecore/savecore.c	Mon Apr 14 21:26:34 2014	(r264478)
+++ head/sbin/savecore/savecore.c	Mon Apr 14 21:44:34 2014	(r264479)
@@ -672,7 +672,7 @@ DoFile(const char *savedir, const char *
 	if (fclose(fp) < 0) {
 		syslog(LOG_ERR, "error on %s: %m", corename);
 		nerr++;
-		goto closeall;
+		goto closefd;
 	}
 
 	symlinks_remove();



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404142144.s3ELiYH5055042>