Date: Mon, 5 Jun 2000 01:50:53 +0100 From: Josef Karthauser <joe@pavilion.net> To: Doug Barton <DougB@gorean.org> Cc: Warner Losh <imp@village.org>, "Matthew N. Dodd" <winter@jurai.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ls extern.h ls.1 ls.c ls.h print.c Message-ID: <20000605015052.J620@pavilion.net> In-Reply-To: <393ADBA7.7A2B5BF9@gorean.org>; from DougB@gorean.org on Sun, Jun 04, 2000 at 03:43:51PM -0700 References: <Pine.BSF.4.21.0006032357500.45538-100000@sasami.jurai.net> <200006042215.QAA53873@harmony.village.org> <393ADBA7.7A2B5BF9@gorean.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 04, 2000 at 03:43:51PM -0700, Doug Barton wrote: > 2. The color options should be #ifdef'ed so that people who need a > slimmer ls can easily build one. (Thus anti-bloatists, picobsd, fixit > floppy people, etc.; can define "NOCOLORINLSNOWAYNOHOW" and be done with > it. :) Agreed. Although it should be NOJOENO :) > 3. First choice for 'ls -G' should be tgetstr(), with the ANSI codes > left in as a fallback if that returns NULL. (Thus handling the case of > no mounted /usr as well as possible.) No, if tgetstr returns NULL then there should be no colour. This is a must to avoid breaking non ANSI terminals. I've got a working patch for this. The only issue left is where in the code to initialise the termcap. Joe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000605015052.J620>