Date: Fri, 30 Dec 2005 11:59:13 +0100 From: Alexander Leidinger <netchild@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: mux@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ums.c Message-ID: <20051230115913.243e3e21@Magellan.Leidinger.net> In-Reply-To: <43B4FDD5.1060000@root.org> References: <20051229183552.205C316A432@hub.freebsd.org> <43B4385D.9030206@root.org> <20051229222645.05311b1f@Magellan.Leidinger.net> <43B4FDD5.1060000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 30 Dec 2005 01:28:53 -0800
Nate Lawson <nate@root.org> wrote:
> >>> #define UMS_BUT(i) ((i) < 3 ? (((i) + 2) % 3) : (i))
> I meant that this maps 0:2, 1:0, 2:1, 3:3, 4:4, ... Or in other words,
> it only operates on 2-bit values (0-3). I don't know if that's an issue
> or not, I just was wondering if that also needed to be expanded.
NetBSD has:
#define UMS_BUT(i) ((i) == 1 || (i) == 2 ? 3 - (i) : i)
So this maps 0:0, 1:2, 2:1, 3:3, 4:4, ... so it's completely different
below 3 and the same for the rest. So for the new buttons 8 to 31 it
doesn't make a difference. Since it also wasn't changed in the
MAX_BUTTONS commit, I didn't merged it.
I think the change was introduced in the uhidev commit, but I didn't
checked this. Maxime (CCed) is working on merging the uhidev stuff,
maybe he knows for sure.
Bye,
Alexander.
--
Weird enough for government work.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051230115913.243e3e21>