Date: Wed, 21 Sep 2005 20:39:20 GMT From: Thierry Thomas <thierry@FreeBSD.org> To: nivit@email.it, thierry@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org, thierry@FreeBSD.org Subject: Re: ports/85801: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus Message-ID: <200509212039.j8LKdKpC071588@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus State-Changed-From-To: open->feedback State-Changed-By: thierry State-Changed-When: Wed Sep 21 20:33:18 GMT 2005 State-Changed-Why: This port is fine, but I would just make a minor suggestion: since DISTNAME is not versioned, it would be easier to maintain if we include PORTVERSION in DIST_SUBDIR. Could you please review the following patch? --- geogebra-i18n.diff begins here --- diff -urN math/geogebra-i18n.orig/Makefile math/geogebra-i18n/Makefile --- math/geogebra-i18n.orig/Makefile Wed Sep 21 22:22:06 2005 +++ math/geogebra-i18n/Makefile Wed Sep 21 22:25:23 2005 @@ -12,7 +12,7 @@ MASTER_SITES= http://www.geogebra.at/download/InstData/Java/ DISTNAME= geogebra_setup EXTRACT_SUFX= .jar -DIST_SUBDIR= ${PORTNAME} +DIST_SUBDIR= ${PORTNAME}-${PORTVERSION} MAINTAINER= nivit@email.it COMMENT= A dynamic software that joins geometry, algebra and calculus @@ -33,8 +33,6 @@ SOURCES_DIR= ${WRKSRC}/D_/deploy/source JARFILE= ${PORTNAME:S/-i18n$//}.jar -.include <bsd.port.pre.mk> - do-install: ${INSTALL_SCRIPT} ${WRKSRC}/${SUB_FILES} ${PREFIX}/bin/${SUB_FILES} cd ${SOURCES_DIR} && ${MKDIR} ${DATADIR} && ${INSTALL_DATA} ${JARFILE} ${DATADIR}; @@ -44,4 +42,5 @@ cd ${SOURCES_DIR} && ${FIND} . ${FIND_DOCS} -exec ${INSTALL_DATA} {} ${DOCSDIR}/{} \; .endif cd ${SOURCES_DIR}/.. && ${FIND} . ${FIND_ICONS} -exec ${INSTALL_DATA} {} ${DATADIR}/{} \; -.include <bsd.port.post.mk> + +.include <bsd.port.mk> diff -urN math/geogebra-i18n.orig/distinfo math/geogebra-i18n/distinfo --- math/geogebra-i18n.orig/distinfo Wed Sep 21 22:04:41 2005 +++ math/geogebra-i18n/distinfo Wed Sep 21 22:26:03 2005 @@ -1,2 +1,2 @@ -MD5 (geogebra-i18n/geogebra_setup.jar) = 61589d1277c0687c1c5ceba9d21db173 -SIZE (geogebra-i18n/geogebra_setup.jar) = 5071911 +MD5 (geogebra-i18n-2.6b/geogebra_setup.jar) = 61589d1277c0687c1c5ceba9d21db173 +SIZE (geogebra-i18n-2.6b/geogebra_setup.jar) = 5071911 --- geogebra-i18n.diff ends here --- Regards, Responsible-Changed-From-To: freebsd-ports-bugs->thierry Responsible-Changed-By: thierry Responsible-Changed-When: Wed Sep 21 20:33:18 GMT 2005 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=85801
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509212039.j8LKdKpC071588>