Date: Fri, 7 Jul 1995 16:10:01 -0700 From: jdp@polstra.com To: freebsd-bugs Subject: bin/599: Bug + fix for pkg_add in 2.0.5-RELEASE Message-ID: <199507072310.QAA27826@freefall.cdrom.com> In-Reply-To: Your message of Fri, 7 Jul 1995 16:06:40 -0700 <199507072306.QAA00998@freebie.polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>Number: 599
>Category: bin
>Synopsis: pkg_add does not stop if dependencies are missing
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs (FreeBSD bugs mailing list)
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Jul 7 16:10:01 1995
>Originator: John Polstra
>Organization:
Polstra & Co., Inc.
>Release: FreeBSD 2.0-BUILT-19950603 i386
>Environment:
FreeBSD 2.0.5-RELEASE, nothing unusual.
>Description:
If pkg_add finds that some dependencies are missing, it reports
them, but then it proceeds to try to install the package. That
results in a partial, non-working installation of the package.
The manual page says that pkg_add should halt under these
circumstances, unless the "-f" option has been supplied on the
command line.
>How-To-Repeat:
Run "pkg_add some-package" where "some-package" is any package
that depends on one or more other packages which have not been
installed on the system.
>Fix:
*** usr.sbin/pkg_install/add/perform.c- Sat Jun 10 02:04:13 1995
--- usr.sbin/pkg_install/add/perform.c Fri Jul 7 14:47:22 1995
***************
*** 256,261 ****
--- 256,265 ----
printf(" - already installed.\n");
}
+ /* Bomb off now, if we have found some missing dependencies */
+ if (code != 0)
+ goto bomb;
+
/* If this is a direct extract and we didn't want it, stop now */
if (where_to != PlayPen && Fake)
goto success;
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507072310.QAA27826>