Date: Fri, 8 Jan 2010 17:41:42 +0100 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= <trasz@FreeBSD.org> To: Stefan Farfeleder <stefanf@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201794 - in head/sys: ddb dev/ep dev/ex netinet6 Message-ID: <D25079D8-2B50-4350-8C9B-C9C6CF45ABE5@FreeBSD.org> In-Reply-To: <20100108161210.GC1610@mole.fafoe.narf.at> References: <201001081544.o08FinVh015359@svn.freebsd.org> <20100108161210.GC1610@mole.fafoe.narf.at>
next in thread | previous in thread | raw e-mail | index | archive | help
Wiadomo=B6=E6 napisana przez Stefan Farfeleder w dniu 2010-01-08, o = godz. 17:12: > On Fri, Jan 08, 2010 at 03:44:49PM +0000, Edward Tomasz Napierala = wrote: >> Author: trasz >> Date: Fri Jan 8 15:44:49 2010 >> New Revision: 201794 >> URL: http://svn.freebsd.org/changeset/base/201794 >>=20 >> Log: >> Replace several instances of 'if (!a & b)' with 'if (!(a &b))' in = order >> to silence newer GCC versions. >=20 > They are not identical, !a & b is parsed as (!a) & b. The code now > seems more correct however. Looks like I've got the operator precedence backwards there - I assumed there was no functional change involved. But yes, the code now looks = more correct - logical 'and' of a constant with the truth value is pointless. -- If you cut off my head, what would I say? Me and my head, or me and my = body?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D25079D8-2B50-4350-8C9B-C9C6CF45ABE5>