Date: Mon, 8 Apr 2013 15:41:27 -0400 From: John Baldwin <jhb@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r249265 - in head/sys: amd64/include arm/include i386/include ia64/include mips/include powerpc/include sparc64/include sys Message-ID: <201304081541.27408.jhb@freebsd.org> In-Reply-To: <201304081919.r38JJAvB088644@svn.freebsd.org> References: <201304081919.r38JJAvB088644@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, April 08, 2013 3:19:10 pm Gleb Smirnoff wrote: > Author: glebius > Date: Mon Apr 8 19:19:10 2013 > New Revision: 249265 > URL: http://svnweb.freebsd.org/changeset/base/249265 > > Log: > Merge from projects/counters: > > Pad struct pcpu so that its size is denominator of PAGE_SIZE. This > is done to reduce memory waste in UMA_PCPU_ZONE zones. > > Sponsored by: Nginx, Inc. > > Modified: head/sys/sys/pcpu.h > ============================================================================== > --- head/sys/sys/pcpu.h Mon Apr 8 19:10:45 2013 (r249264) > +++ head/sys/sys/pcpu.h Mon Apr 8 19:19:10 2013 (r249265) > @@ -180,6 +180,14 @@ struct pcpu { > PCPU_MD_FIELDS; > } __aligned(CACHE_LINE_SIZE); Why not change this to be PAGE_SIZE rather than putting explicit padding in all the pcpu fields? That would seem to be more maintainable. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304081541.27408.jhb>