Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Jan 2015 06:22:13 -0500
From:      Randy Stewart <randall@lakerest.net>
To:        Randall Ray Stewart <randall@lakerest.net>
Cc:        Hans Petter Selasky <hps@selasky.org>, Adrian Chadd <adrian@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Kip Macy <kmacy@freebsd.org>, Jason Wolfe <nitroboost@gmail.com>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, "M. Warner Losh" <imp@bsdimp.com>
Subject:   Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys
Message-ID:  <4E451459-6993-49E8-BB33-502DC0D82C19@lakerest.net>
In-Reply-To: <BEEA40C8-0698-4063-9B64-D170578B75D0@lakerest.net>
References:  <20150120075126.GA42409@kib.kiev.ua> <20150120211137.GY15484@FreeBSD.org> <54BED6FB.8060401@selasky.org> <54BEE62D.2060703@ignoranthack.me> <CAHM0Q_MDJN_8sTvTDXfqA7UtJVO3Y8S8%2BNRCs_=6Nj4dkTzjOA@mail.gmail.com> <54BEE8E6.3080009@ignoranthack.me> <CAHM0Q_N_53BM-6RvXu8UpjfDzQHEn5oXZo1Nn8RO0cuOUhe8tg@mail.gmail.com> <54BEEA7F.1070301@ignoranthack.me> <CAHM0Q_PtJ7JHFTiu9_dmi_Ce=rmu1j72z2OYQ2CD3%2BEbcoEGsA@mail.gmail.com> <54BEF154.3030606@ignoranthack.me> <20150121181512.GE15484@FreeBSD.org> <CAJ-VmokyKX0uCA1%2B3KjziJkokDOVBCpUdwHQcVaY=buwa%2BqfhQ@mail.gmail.com> <CAHM0Q_NJDq41MtDAne0a-fnp%2BOg38=ypNKRidq5cAeL=nj-YDQ@mail.gmail.com> <B4F512FF-5AD8-4885-9ABF-CEAB54561F92@bsdimp.com> <CAHM0Q_M%2BKkiGOxMcFjZD-Sqxu6bzY_AvGbJHsadbFAgPvbM55Q@mail.gmail.com> <CAJ-VmomObs2gMFLCZzXPSu8w7JwommXZ_MZPfRKx3mmHTe3eyw@mail.gmail.com> <BEEA40C8-0698-4063-9B64-D170578B75D0@lakerest.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Hans:

I think this is the wrong approach.

You should:

a) Back out the commit you did to head
b) create a project branch and put your changes in there
c) fix *everything* you break in these subtle ways
d) Discuss through a review process if your changes are correct
e) When consensus is reached then and only then put it into head
   with all the fixes.

If you are not willing to do the above, then we need this taken up
to core and have them act on it. I think enough folks have voiced concern
that you should be willing to do the above steps.

R
> On Jan 22, 2015, at 12:19 AM, Randy Stewart <randall@lakerest.net> wrote:
> 
> All:
> 
> I have finally pulled my head out of the sands of TLS and 
> had some time to look at this interesting long thread. I agree
> with Warner and Adrian on this.. Lets back it out
> and then in a branch chew this over piece by piece..
> 
> R

-----
Randall Stewart
randall@lakerest.net







Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E451459-6993-49E8-BB33-502DC0D82C19>