Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Apr 2004 12:09:11 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Bosko Milekic <bmilekic@freebsd.org>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sbin/mount Makefile mount.c src/sys/ufs/ffs    ffs_vfsops.c
Message-ID:  <20040427115536.W7721@gamplex.bde.org>
In-Reply-To: <200404261513.i3QFDkb5026044@repoman.freebsd.org>
References:  <200404261513.i3QFDkb5026044@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 26 Apr 2004, Bosko Milekic wrote:

> bmilekic    2004/04/26 08:13:46 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     sbin/mount           Makefile mount.c
>     sys/ufs/ffs          ffs_vfsops.c
>   Log:
>   The previous change to mount(8) to report ufs or ufs2 used
>   libufs, which only works for Charlie root.
>
>   This change reverts the introduction of libufs and moves the
>   check into the kernel.  Since the f_fstypename is the same
>   for both ufs and ufs2, we check fs_magic for presence of
>   ufs2 and copy "ufs2" explicitly instead.

This seems to fix things like "mount -t ufs" and "find / -fstype ufs"
to not work with ufs2.  Many scripts may depend on this.

Is it too late to fix the misspelling of "ffs" as "ufs"?

The patch has some bugs (mainly clobbering of mp->mnt_stat.f_fstypename
via an alias in the first part of the change to ffs_statfs(), so the
larger second part of the change is a no-op).  Details in private mail.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040427115536.W7721>