Date: Sat, 8 Apr 2006 05:08:17 +0000 (UTC) From: Scott Long <scottl@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h Message-ID: <200604080508.k3858ImJ074610@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
scottl 2006-04-08 05:08:17 UTC FreeBSD src repository Modified files: sys/dev/amr amr.c amr_pci.c amrvar.h Log: After further review and discussion, partially revert the previous commit. The real problem was that ioctl handlers needed to call amr_wait_command() with the list lock held. This not only solves the completion race, it also prevents bounce buffer corruption that could arise from amr_start() being called without the proper locks held. Discussed with: ps MFC After: 3 days Revision Changes Path 1.77 +13 -18 src/sys/dev/amr/amr.c 1.36 +0 -1 src/sys/dev/amr/amr_pci.c 1.32 +0 -1 src/sys/dev/amr/amrvar.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604080508.k3858ImJ074610>