Date: Fri, 18 Jul 1997 13:57:41 +0900 (JST) From: itojun@itojun.org To: bugs@freebsd.org Cc: ishii@csl.sony.co.jp, rt-bone@wide.ad.jp Subject: net/if_spppsubr.c: can't talk with cisco via HDLC Message-ID: <199707180457.NAA17764@itojun.csl.sony.co.jp>
next in thread | raw e-mail | index | archive | help
>Submitter-Id: itojun >Originator: Jun-ichiro ITOH >Organization: itojun.org >Confidential: no >Synopsis: net/if_spppsubr.c broken (can't talk with cisco via HDLC) >Severity: serious >Priority: high >Category: net >Class: sw-bug >Release: FreeBSD-current >Environment: latest source on cvs repository has this bug too. >Description: FreeBSD box + riscomN2pci can't talk to cisco by using CISCO HDLC IP encapsulation. credit goes to ishii@csl.sony.co.jp (Kimio Ishii). >How-To-Repeat: try to talk with cisco, by CISCO HDLC. >Fix: apply this patch. (it is based on slightly modified source, but it should be trivial) if there's no objection, I can commit it myself. --- if_spppsubr.c-dist Fri Jul 18 13:29:11 1997 +++ if_spppsubr.c Fri Jul 18 13:32:37 1997 @@ -920,7 +920,7 @@ struct ifaddr *ifa; struct ifnet *ifp = &sp->pp_if; - if (m->m_pkthdr.len != CISCO_PACKET_LEN) { + if (m->m_pkthdr.len < CISCO_PACKET_LEN) { if (ifp->if_flags & IFF_DEBUG) printf ("%s%d: invalid cisco packet length: %d bytes\n", ifp->if_name, ifp->if_unit, m->m_pkthdr.len);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199707180457.NAA17764>