Date: Sat, 13 Nov 2004 08:08:47 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Don Lewis <truckman@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: kernel panic in free() called from semop() Message-ID: <Pine.NEB.3.96L.1041113080524.26498D-100000@fledge.watson.org> In-Reply-To: <200411122312.iACNBvVv067706@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry about that, fixes committed! On Fri, 12 Nov 2004, Don Lewis wrote: > @@ -900,7 +901,7 @@ semop(td, uap) > semid = IPCID_TO_IX(semid); /* Convert back to zero origin */ > > if (semid < 0 || semid >= seminfo.semmni) > - return (EINVAL); > + error = EINVAL; This was part of a second set of changes that I haven't yet merged, which slipped through while I was breaking out the ABI changes. > @@ -1152,6 +1153,7 @@ done2: > mtx_unlock(sema_mtxp); > if (sops != small_sops) > free(sops, M_SEM); > + free(sops, M_SEM); > return (error); > } And this is from incorrectly merging the small_sops change to the TrustedBSD branch when it was originally committed. I thought I'd gone through the patches pretty carefully for this sort of thing, but I guess after reading through three files of the system v IPC code, the eyes go numb. Thanks, Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1041113080524.26498D-100000>