Date: Thu, 22 Jan 2015 22:09:41 +0100 From: Nikos Vassiliadis <nvass@gmx.com> To: Gleb Smirnoff <glebius@FreeBSD.org>, Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <54C16715.6060701@gmx.com> In-Reply-To: <20150122012709.GM15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/22/15 02:27, Gleb Smirnoff wrote: > On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: > C> Author: rodrigc > C> Date: Tue Jan 6 09:03:03 2015 > C> New Revision: 276747 > C> URL: https://svnweb.freebsd.org/changeset/base/276747 > C> > C> Log: > C> Instead of creating a purge thread for every vnet, create > C> a single purge thread and clean up all vnets from this thread. > C> > C> PR: 194515 > C> Differential Revision: D1315 > C> Submitted by: Nikos Vassiliadis <nvass@gmx.com> > > Sorry guys, I backed this out due to broken kldunload of pf module, which > is critical when you are working with pf bugs. For sure. 100% understood. > I had to backout r276746 as well, since it has numerous build breakages, > that are addressed by later revisions. > > That's my fault that I don't review in time, and I will try to improve > the situation. > > Can you please replay r276746 again, addressing all the build problems > and send the patch to me? You can user reviews.freebsd.org if you want. > > I'd like to get this in, but in a better quality. I'd like to get involved again and help you fixing pf. Craig could you replay 276746? I can try fixing the pf purge thread. Thanks, Nikos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54C16715.6060701>