Date: Wed, 11 May 2016 16:43:22 -0400 From: Ed Maste <emaste@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r299480 - head/secure/lib/libcrypto Message-ID: <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com> In-Reply-To: <201605112006.u4BK6NNd095917@repo.freebsd.org> References: <201605112006.u4BK6NNd095917@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 May 2016 at 16:06, Jung-uk Kim <jkim@freebsd.org> wrote: > Author: jkim > Date: Wed May 11 20:06:23 2016 > New Revision: 299480 > URL: https://svnweb.freebsd.org/changeset/base/299480 > [...] > ( echo '# $$'FreeBSD'$$' ;\ > echo '# Do not modify. This file is auto-generated from ${.IMPSRC:T}.' ;\ > echo '#ifdef PIC' ;\ > - perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\ > + env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\ > echo '#else' ;\ > - perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\ > + env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\ One thing that occurred to me in the older PIC change here: perhaps we should explicitly strip -fpic / -DPIC from the passed-in ${CFLAGS} for the #else. It's unlikely, but possible, that a user could regenerate the assembly files with -fpic set in CFLAGS.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg>