Date: Mon, 12 Aug 2002 12:29:49 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: Bruce Evans <bde@zeta.org.au>, Terry Lambert <tlambert2@mindspring.com>, David Xu <bsddiy@yahoo.com>, Julian Elischer <julian@elischer.org>, FreeBSD CURRENT <freebsd-current@FreeBSD.ORG> Subject: Re: cvs commit: src/sys/kern kern_sig.c (fwd) Message-ID: <20020812192949.GB4787@dragon.nuxi.com> In-Reply-To: <20020812172131.GA2139@nagual.pp.ru> References: <20020812113101.GA2089@nagual.pp.ru> <20020813031235.O25510-100000@gamplex.bde.org> <20020812172131.GA2139@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 12, 2002 at 09:21:31PM +0400, Andrey A. Chernov wrote: > On Tue, Aug 13, 2002 at 03:15:02 +1000, Bruce Evans wrote: > > > > Anyway, it has one blatant style bug (not 1TBS) and no explanation of > > the bug, so it should not have been committed verbatim. See another > > reply for an analysis of the patch. > > According to commit guide, explanations are not commited, only what is > changed. For explanation (terminal group mismatch) read whole thread, > especially David's analysis. Wrong Andrey. For hairy code, there should be comments -- especially if one must realize someone obtuse to understand how the code works. 6mo. from now no one will be able to find the explanation in a mailing list. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020812192949.GB4787>