Date: Mon, 20 Jun 2016 12:57:03 -0300 From: Luiz Otavio O Souza <loos.br@gmail.com> To: Maxim Sobolev <sobomax@sippysoft.com> Cc: Jim Thompson <jim@netgate.com>, Svatopluk Kraus <onwahe@gmail.com>, "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: BBB (cpsw(4)) seems to be broken in the latest 11-current Message-ID: <CAJ8CS7qEAjhON6vBL2%2Bh5u=EOK20jnSFzRV1%2BsF3a-GUhLjHoQ@mail.gmail.com> In-Reply-To: <CAH7qZfvAh-dSRYM7G1BkpgMZc3zkeSDakj7LOO=s2JF%2BUy=eUw@mail.gmail.com> References: <CAH7qZfsMiUSCTG827ysO89o9nH9WAKu4w%2BiZPZ-UKKVa6T2pcA@mail.gmail.com> <CAFHCsPWUFDiM%2BQh6EkNKPdbm0BrqtgStdzig4WyFmj8L31qN%2Bg@mail.gmail.com> <CAH7qZftdjhrp_m440BPHeArSnV-QQmghm4UyMJ3qro75NMGPQA@mail.gmail.com> <83A18C0E-FA89-4009-A8D5-3185FB27A688@netgate.com> <CAH7qZfvRB4y=GP9yjCAjjBy2h3pHTifdm0t%2BTTVFONQNPe9=8w@mail.gmail.com> <CAH7qZfvAh-dSRYM7G1BkpgMZc3zkeSDakj7LOO=s2JF%2BUy=eUw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a114452e26b900a0535b7c1e7 Content-Type: text/plain; charset=UTF-8 On Sun, Jun 19, 2016 at 1:11 AM, Maxim Sobolev wrote: > Jim, some update from here. Running r283287 of the driver, I still see the > same "watchdog timeout" messages, but they do not lead to the interface > lockout. The traffic resumes momentarily. Which is probably why I never paid > much attention to those warnings before. Therefore, I suspect that the new > MAC code does not deal with watchdog-triggered interface reset as good as > the old code. Does it give you any ideas about what could be wrong there by > any chance? Hi Maxim, My recent changes contributed somehow to expose the bug more frequently. There was a condition in tx packet reclamation where we aren't restarting the tx queue in one of the possible stall conditions. Please try the attached patch and let me know if it works for you. Luiz --001a114452e26b900a0535b7c1e7 Content-Type: text/plain; charset=US-ASCII; name="cpsw-eoq-restart.diff" Content-Disposition: attachment; filename="cpsw-eoq-restart.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ipo6vinw0 SW5kZXg6IHN5cy9hcm0vdGkvY3Bzdy9pZl9jcHN3LmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2FybS90 aS9jcHN3L2lmX2Nwc3cuYwkocmV2aXNpb24gMzAxOTc1KQorKysgc3lzL2FybS90aS9jcHN3L2lm X2Nwc3cuYwkod29ya2luZyBjb3B5KQpAQCAtMTg3NCw2ICsxODc0LDcgQEAKIAkJcmV0dXJuOwog CX0gZWxzZSBpZiAobGFzdF9vbGRfc2xvdCA9PSBOVUxMKSB7CiAJCS8qIFN0YXJ0IGEgZnJlc2gg cXVldWUuICovCisJCXNjLT5zd3NjLT5sYXN0X2hkcCA9IGNwc3dfY3BkbWFfYmRfcGFkZHIoc2Mt PnN3c2MsIGZpcnN0X25ld19zbG90KTsKIAkJY3Bzd193cml0ZV9oZHBfc2xvdChzYy0+c3dzYywg JnNjLT5zd3NjLT50eCwgZmlyc3RfbmV3X3Nsb3QpOwogCX0gZWxzZSB7CiAJCS8qIEFkZCBidWZm ZXJzIHRvIGVuZCBvZiBjdXJyZW50IHF1ZXVlLiAqLwpAQCAtMTg4Miw2ICsxODgzLDcgQEAKIAkJ LyogSWYgdW5kZXJydW4sIHJlc3RhcnQgcXVldWUuICovCiAJCWlmIChjcHN3X2NwZG1hX3JlYWRf YmRfZmxhZ3Moc2MtPnN3c2MsIGxhc3Rfb2xkX3Nsb3QpICYKIAkJICAgIENQRE1BX0JEX0VPUSkg eworCQkJc2MtPnN3c2MtPmxhc3RfaGRwID0gY3Bzd19jcGRtYV9iZF9wYWRkcihzYy0+c3dzYywg Zmlyc3RfbmV3X3Nsb3QpOwogCQkJY3Bzd193cml0ZV9oZHBfc2xvdChzYy0+c3dzYywgJnNjLT5z d3NjLT50eCwKIAkJCSAgICBmaXJzdF9uZXdfc2xvdCk7CiAJCX0KQEAgLTE4OTcsNiArMTg5OSw3 IEBACiBjcHN3X3R4X2RlcXVldWUoc3RydWN0IGNwc3dfc29mdGMgKnNjKQogewogCXN0cnVjdCBj cHN3X3Nsb3QgKnNsb3QsICpsYXN0X3JlbW92ZWRfc2xvdCA9IE5VTEw7CisJc3RydWN0IGNwc3df Y3BkbWFfYmQgYmQ7CiAJdWludDMyX3QgZmxhZ3MsIHJlbW92ZWQgPSAwOwogCiAJc2xvdCA9IFNU QUlMUV9GSVJTVCgmc2MtPnR4LmFjdGl2ZSk7CkBAIC0xOTMxLDcgKzE5MzQsOCBAQAogCQl9CiAK IAkJLyogVGVhckRvd24gY29tcGxldGUgaXMgb25seSBtYXJrZWQgb24gdGhlIFNPUCBmb3IgdGhl IHBhY2tldC4gKi8KLQkJaWYgKGZsYWdzICYgQ1BETUFfQkRfVERPV05DTVBMVCkgeworCQlpZiAo KGZsYWdzICYgKENQRE1BX0JEX1NPUCB8IENQRE1BX0JEX1RET1dOQ01QTFQpKSA9PQorCQkgICAg KENQRE1BX0JEX0VPUCB8IENQRE1BX0JEX1RET1dOQ01QTFQpKSB7CiAJCQlDUFNXX0RFQlVHRihz YywgKCJUWCB0ZWFyZG93biBpbiBwcm9ncmVzcyIpKTsKIAkJCWNwc3dfd3JpdGVfY3Aoc2MsICZz Yy0+dHgsIDB4ZmZmZmZmZmMpOwogCQkJLy8gVE9ETzogSW5jcmVtZW50IGEgY291bnQgb2YgZHJv cHBlZCBUWCBwYWNrZXRzCkBAIC0xOTM4LDYgKzE5NDIsMTYgQEAKIAkJCXNjLT50eC5ydW5uaW5n ID0gMDsKIAkJCWJyZWFrOwogCQl9CisKKwkJaWYgKChmbGFncyAmIENQRE1BX0JEX0VPUCkgPT0g MCkKKwkJCWZsYWdzID0gY3Bzd19jcGRtYV9yZWFkX2JkX2ZsYWdzKHNjLCBsYXN0X3JlbW92ZWRf c2xvdCk7CisJCWlmICgoZmxhZ3MgJiAoQ1BETUFfQkRfRU9QIHwgQ1BETUFfQkRfRU9RKSkgPT0K KwkJICAgIChDUERNQV9CRF9FT1AgfCBDUERNQV9CRF9FT1EpKSB7CisJCQljcHN3X2NwZG1hX3Jl YWRfYmQoc2MsIGxhc3RfcmVtb3ZlZF9zbG90LCAmYmQpOworCQkJaWYgKGJkLm5leHQgIT0gMCAm JiBiZC5uZXh0ICE9IHNjLT5sYXN0X2hkcCkKKwkJCQkvKiBSZXN0YXJ0IHRoZSBxdWV1ZS4gKi8K KwkJCQljcHN3X3dyaXRlXzQoc2MsIHNjLT50eC5oZHBfb2Zmc2V0LCBiZC5uZXh0KTsKKwkJfQog CX0KIAogCWlmIChyZW1vdmVkICE9IDApIHsKSW5kZXg6IHN5cy9hcm0vdGkvY3Bzdy9pZl9jcHN3 dmFyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gc3lzL2FybS90aS9jcHN3L2lmX2Nwc3d2YXIuaAkocmV2aXNp b24gMzAxOTc1KQorKysgc3lzL2FybS90aS9jcHN3L2lmX2Nwc3d2YXIuaAkod29ya2luZyBjb3B5 KQpAQCAtODMsNiArODMsNyBAQAogCiAJLyogUlggYW5kIFRYIGJ1ZmZlciB0cmFja2luZyAqLwog CXN0cnVjdCBjcHN3X3F1ZXVlIHJ4LCB0eDsKKwl1aW50MzJfdAlsYXN0X2hkcDsKIAogCS8qIFdl IGV4cGVjdCAxIG1lbW9yeSByZXNvdXJjZSBhbmQgNCBpbnRlcnJ1cHRzIGZyb20gdGhlIGRldmlj ZSB0cmVlLiAqLwogCWludAkJbWVtX3JpZDsK --001a114452e26b900a0535b7c1e7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ8CS7qEAjhON6vBL2%2Bh5u=EOK20jnSFzRV1%2BsF3a-GUhLjHoQ>