Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 31 Aug 2005 16:03:01 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netinet tcp_syncache.c
Message-ID:  <20050831140301.GB791@garage.freebsd.pl>
In-Reply-To: <200508311356.j7VDuG2v098047@repoman.freebsd.org>
References:  <200508311356.j7VDuG2v098047@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--/NkBOFFp2J2Af1nK
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 31, 2005 at 01:56:15PM +0000, Gleb Smirnoff wrote:
+> glebius     2005-08-31 13:56:15 UTC
+>=20
+>   FreeBSD src repository
+>=20
+>   Modified files:        (Branch: RELENG_6)
+>     sys/netinet          tcp_syncache.c=20
+>   Log:
+>   MFC 1.76:
+>     - Refuse hashsize of 0, since it is invalid.
[...]
+> -	if (!powerof2(tcp_syncache.hashsize)) {
+> +	if (!powerof2(tcp_syncache.hashsize) || tcp_syncache.hashsize =3D=3D 0=
) {

I ran into this as well. The problem here is powerof2() macro and the macro
should be fixed: 0 is not a power of 2.

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--/NkBOFFp2J2Af1nK
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)

iD8DBQFDFbiVForvXbEpPzQRAu7wAKDOsH0o7OlHmpUwdQwVg+eiDIdcLwCg0rqw
u86A1ThbGW38r2mu2Qio/fw=
=eKwV
-----END PGP SIGNATURE-----

--/NkBOFFp2J2Af1nK--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050831140301.GB791>