Date: Wed, 2 Oct 2002 21:14:38 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 18572 for review Message-ID: <200210030414.g934EcQw017897@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18572 Change 18572 by rwatson@rwatson_tislabs on 2002/10/02 21:13:55 Back out apparent incorrect solution to problems with extended attributes on specfs vnodes in UFS2. Vnode operation vectors default to eopnotsupp unless overridden, so the change in question was essentially a noop. It also didn't fix the problem with EAs, which relates to VOP_WRITE() being implemented by specfs not ffs, and therefore the IO_EXT components of the write not getting directed to the right implementation. This is one potential problem with choosing to implement extended attribute operations using the existing ffs_readwrite implementation, as it composes improperly when you have pseudo-file systems like specfs. Affected files ... .. //depot/projects/trustedbsd/mac/sys/fs/specfs/spec_vnops.c#12 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/fs/specfs/spec_vnops.c#12 (text+ko) ==== @@ -107,10 +107,6 @@ { &vop_lock_desc, (vop_t *) vop_nolock }, { &vop_unlock_desc, (vop_t *) vop_nounlock }, { &vop_islocked_desc, (vop_t *) vop_noislocked }, - { &vop_getextattr_desc, (vop_t *) vop_eopnotsupp }, - { &vop_setextattr_desc, (vop_t *) vop_eopnotsupp }, - { &vop_openextattr_desc, (vop_t *) vop_eopnotsupp }, - { &vop_closeextattr_desc, (vop_t *) vop_eopnotsupp }, { NULL, NULL } }; static struct vnodeopv_desc spec_vnodeop_opv_desc = To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210030414.g934EcQw017897>