Date: Mon, 17 Jul 2006 16:27:56 -0400 From: John Baldwin <jhb@freebsd.org> To: Paolo Pisati <piso@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 101794 for review Message-ID: <200607171627.56827.jhb@freebsd.org> In-Reply-To: <200607171946.k6HJkFLs031826@repoman.freebsd.org> References: <200607171946.k6HJkFLs031826@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 17 July 2006 15:46, Paolo Pisati wrote: > http://perforce.freebsd.org/chv.cgi?CH=101794 > > Change 101794 by piso@piso_newluxor on 2006/07/17 19:45:55 > > Obviously if we return different ORed values, we use & > instead of == to check the return value. I guess this fixes your problem. :) > Affected files ... > > .. //depot/projects/soc2006/intr_filter/kern/kern_intr.c#8 edit > > Differences ... > > ==== //depot/projects/soc2006/intr_filter/kern/kern_intr.c#8 (text+ko) ==== > > @@ -798,14 +798,14 @@ > } > > /* Mark handler for later execution in ithread. */ > - if (ret2 == FILTER_SCHEDULE_THREAD) { > + if (ret2 & FILTER_SCHEDULE_THREAD) { > ih->ih_need = 1; > ret |= FILTER_SCHEDULE_THREAD; > continue; > } > > /* Interrupt served in filter. */ > - if (ret2 == FILTER_HANDLED) { > + if (ret2 & FILTER_HANDLED) { > ret |= FILTER_HANDLED; > return (ret); > } > -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607171627.56827.jhb>