Date: Fri, 5 Oct 2012 13:23:49 GMT From: Manuel <manuel-freebsd@mausz.at> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/172355: [PATCH] ports-mgmt/portconf: allow dash and plus symbols in variable names Message-ID: <201210051323.q95DNnvn074318@red.freebsd.org> Resent-Message-ID: <201210051330.q95DUGcO055988@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 172355
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portconf: allow dash and plus symbols in variable names
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Oct 05 13:30:14 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Manuel
>Release:
>Organization:
>Environment:
>Description:
Please add dash (-) and plus (+) symbols to allowed characters in variable names:
Dash symbols are required when using OptionsNG and $UNIQUENAME_SET/UNSET. e.g. apache22-event-mpm_SET=...
Plus symbols can be used to extend existing variables. e.g. OPTIONS_SET+=...
>How-To-Repeat:
>Fix:
--- /usr/local/libexec/portconf.orig 2012-10-05 14:47:42.000000000 +0200
+++ /usr/local/libexec/portconf 2012-10-05 15:14:08.000000000 +0200
@@ -36,7 +36,7 @@
sed '/^#/d;/^[[:space:]]*$/d' "${_conf}" | while read _line; do
for _port in ${_line%%:*}; do
if [ "${_pwd%%${_port}}" != "${_pwd}" ]; then
- echo ${_line#*:} | sed -E 's/([A-Za-z0-9_]+)(=([^|]+))?/\1=\3/g;s/!([A-Za-z0-9_]+)=([^|]+)?/.undef \1/g;s/ *\| */|/g;s/ /%/g'
+ echo ${_line#*:} | sed -E 's/([A-Za-z0-9_\-]+\+?)(=([^|]+))?/\1=\3/g;s/!([A-Za-z0-9_]+)=([^|]+)?/.undef \1/g;s/ *\| */|/g;s/ /%/g'
fi
done
done
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210051323.q95DNnvn074318>