Date: Thu, 10 Nov 2005 19:23:27 +0000 From: Ceri Davies <ceri@submonkey.net> To: Maxime Henrion <mux@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ls ls.1 ls.c Message-ID: <20051110192327.GJ94004@submonkey.net> In-Reply-To: <20051110184926.GC1327@elvis.mu.org> References: <200511100002.jAA02WdF018212@repoman.freebsd.org> <20051110143615.GG94004@submonkey.net> <20051110184926.GC1327@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--1fZJyN7nFm/tosmV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 10, 2005 at 07:49:26PM +0100, Maxime Henrion wrote: > Ceri Davies wrote: > > On Thu, Nov 10, 2005 at 12:02:32AM +0000, Maxime Henrion wrote: > > > mux 2005-11-10 00:02:32 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > bin/ls ls.1 ls.c=20 > > > Log: > > > Add a -I option to disable the automatic -A flag for the super-user. > > > =20 > > > PR: bin/86710 > > > Submitted by: Marcus Alves Grando > > > MFC after: 3 days > >=20 > > For what it's worth, I think mnag was right in the PR when he said that > > this (at least the !getuid() bit) should be changed: > >=20 > > > | + /* Root is -A automatically. */ > > > | + if (!getuid() && !f_nolistdot) > > > | + f_listdot =3D 1; >=20 > I don't mind the change from if (!getuid()) to if (getuid() =3D=3D 0) sin= ce > it is more correct WRT style(9), but what was suggested in the PR by > Giorgos (not mnag@) was to change all the if (!f_foo) and if (f_foo) to > an "expanded" form. Or at least this is what mnag@ did in his second > patch. Anyways, I don't think this is a reasonable change; the f_foo > variables are really boolean and it's simpler if we treat them as is, > and moreover, if people really want to do it this way, it can and should > be done in a separate commit. >=20 > As for the getuid() condition, feel free to change it. Sorry, that was the only one I cared about. > > I'm also struggling for the motivation behind this option, but it > > doesn't actually affect me in any way whatsoever so I can't complain. >=20 > It seems both weird and frustrating that this automatic -A option for root > can't be disabled. I personally don't mind it, but two different people > requested this feature on IRC, plus a third one sent a patch to > implement it so I don't see why it shouldn't get committed. I'm > actually rather annoyed to have to justify committing such a minor ~15 > lines patch. I wasn't after justification. I'm not sure how much more dismissive I could have been. Ceri --=20 Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. -- Einstein (attrib.) --1fZJyN7nFm/tosmV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDc54vocfcwTS3JF8RArFHAKCZAZumLELqdoR9q+u3181yF6lJRACgtc99 ZYq3N5bofu/CDPS4vKjprQ4= =OZ8R -----END PGP SIGNATURE----- --1fZJyN7nFm/tosmV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051110192327.GJ94004>