Date: Fri, 26 Jan 1996 16:00:31 +1100 From: Bruce Evans <bde@zeta.org.au> To: pst@shockwave.com, scrappy@ki.net Cc: current@FreeBSD.ORG Subject: Re: ether_sprintf bug: possible patch? Message-ID: <199601260500.QAA19967@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>no, just re sup and you should be ok, that patch takes us backwards, %D isn't
>used anumore as far as I recall...
Re sup in a day or two. %D is too new to be used in all cases where it
should be, and ether_sprintf() went away while it was still used.
> <excerpt from if_ed.c>
> /*
> * Print additional info when attached
> */
> printf("ed%d: address %6D, ", isa_dev->id_unit,
> sc->arpcom.ac_enaddr, ":");
> assuming that the following "patch" would work or break something? I'm
> going to to try it, but, if I'm missing something due to ignorance... :(
>
> *** if_ep.c.orig Thu Jan 25 16:28:22 1996
> --- if_ep.c Thu Jan 25 16:28:53 1996
> ***************
> *** 408,414 ****
> GO_WINDOW(2);
> outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i]));
> }
> ! printf(" address %s", ether_sprintf(sc->arpcom.ac_enaddr));
>
> /*
> * Write IRQ value to board
> --- 408,414 ----
> GO_WINDOW(2);
> outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i]));
> }
> ! printf(" address %6D", sc->arpcom.ac_enaddr);
>
> /*
> * Write IRQ value to board
Not quite. %D takes 2 args. See if_ed.c.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601260500.QAA19967>