Date: Thu, 25 Jun 2015 15:18:48 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: marino@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r390559 - head/ftp/vsftpd-ext Message-ID: <20150625121847.GE93665@hades.panopticon> In-Reply-To: <558BEF7E.3080602@marino.st> References: <201506251134.t5PBYEir022391@svn.freebsd.org> <558BE843.6040001@marino.st> <20150625120314.GD93665@hades.panopticon> <558BEF7E.3080602@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Marino (freebsd.contact@marino.st) wrote: > >>> Author: amdmi3 > >>> Date: Thu Jun 25 11:34:13 2015 > >>> New Revision: 390559 > >>> URL: https://svnweb.freebsd.org/changeset/ports/390559 > >>> > >>> Log: > >>> - Mark BROKEN on 9.x i386: > >>> > >>> sysutil.c:(.text+0x13da): undefined reference to `__stack_chk_fail_local' > >>> > >>> Approved by: portmgr blanket > >>> Reported by: pkg-fallout > >>> > >>> Modified: > >>> head/ftp/vsftpd-ext/Makefile > >>> > >>> Modified: head/ftp/vsftpd-ext/Makefile > >>> ============================================================================== > >>> --- head/ftp/vsftpd-ext/Makefile Thu Jun 25 11:19:54 2015 (r390558) > >>> +++ head/ftp/vsftpd-ext/Makefile Thu Jun 25 11:34:13 2015 (r390559) > >>> @@ -42,6 +42,9 @@ CONFLICTS= vsftpd-3* vsftpd${SSL_SUFFIX} > >>> .if ${OPSYS} == FreeBSD && ${OSVERSION} < 902001 > >>> BUILD_DEPENDS+= clang33:${PORTSDIR}/lang/clang33 > >>> CC= clang33 > >>> +.if ${ARCH} == i386 > >>> +BROKEN= does not build on 9.x i386 > >>> +.endif > >>> .endif > >> > >> Should that be "BROKEN_FreeBSD_9" ? > > > > No, as the patch says, it only affects i386. > > sorry, I was not clear enough. > I meant: > > .if ${ARCH} == i386 > BROKEN_FreeBSD-9= does not build on 9.x i386 > .endif > > But it's academic. The BROKEN is encapsulated by ".if ${OPSYS} == > FreeBSD && ${OSVERSION} < 902001" so it makes no difference. I've though of it and decided that it's better not to mix and duplicate old and new logic. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150625121847.GE93665>