Date: Fri, 3 Dec 2004 12:50:40 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: "M. Warner Losh" <imp@bsdimp.com> Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci.c Message-ID: <20041203205040.GA16617@ns1.xcllnt.net> In-Reply-To: <20041203.132650.04772724.imp@bsdimp.com> References: <200412030813.iB38DA12044595@repoman.freebsd.org> <20041203.110520.54185564.imp@bsdimp.com> <20041203194201.GB16093@ns1.xcllnt.net> <20041203.132650.04772724.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 03, 2004 at 01:26:50PM -0700, M. Warner Losh wrote: > : > We likely should have a sys/$MACHINE_ARCH/include/_config.h that has a > : > bunch of #defines that we can test instead of specific architecture > : > lists, don't you think? > : > : A <machine/_config.h> doesn't give me warm fuzzies. Maybe we can > : rename <machine/pci_cfgreg.h> to <machine/pci.h> and give it some > : additional use (for this particular case of course). > > There's a growing number of these sorts of things. NetBSD has this > information in machine/types.h. For example: > > #include <mips/types.h> > > #define __HAVE_GENERIC_SOFT_INTERRUPTS > #define __HAVE_DEVICE_REGISTER > #define __HAVE_NWSCONS > > #define __HAVE_MIPS_MACHDEP_CACHE_CONFIG > > I was thinking that we should start doing something similar... For some reason I have a bad feeling about this. It's soooo easily misused. For one, it's a good way to cover up a bad design or an incomplete implementation. It goes no further than a feeling though. There's nothing wrong with it in principle, because differences do exist. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041203205040.GA16617>