Date: Mon, 29 Sep 2014 13:10:03 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272281 - head/lib/libpam/modules/pam_login_access Message-ID: <A31E0109-A986-451F-8472-D548868AD4AD@FreeBSD.org> In-Reply-To: <201409291036.s8TAaFUs040310@svn.freebsd.org> References: <201409291036.s8TAaFUs040310@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 29 Sep 2014, at 12:36, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: > Author: bz > Date: Mon Sep 29 10:36:14 2014 > New Revision: 272281 > URL: http://svnweb.freebsd.org/changeset/base/272281 >=20 > Log: > Hopefully fix build breakage with gcc passing void * instead of char = * > to "%s" format string after r272280. >=20 > PR: 83099 193927 > MFC after: 3 days > X-MFC with: r272280 >=20 > Modified: > head/lib/libpam/modules/pam_login_access/pam_login_access.c >=20 > Modified: head/lib/libpam/modules/pam_login_access/pam_login_access.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/lib/libpam/modules/pam_login_access/pam_login_access.c = Mon Sep 29 08:57:36 2014 (r272280) > +++ head/lib/libpam/modules/pam_login_access/pam_login_access.c = Mon Sep 29 10:36:14 2014 (r272281) > @@ -94,7 +94,8 @@ pam_sm_acct_mgmt(pam_handle_t *pamh, int > PAM_VERBOSE_ERROR("%s is not allowed to log in on %s", > user, tty); > } else { > - PAM_LOG("Checking login.access for user %s", user); > + PAM_LOG("Checking login.access for user %s", > + (const char *)user); > if (login_access(user, "***unknown***") !=3D 0) > return (PAM_SUCCESS); > PAM_VERBOSE_ERROR("%s is not allowed to log in", user); >=20 Just a few lines after the one you fixed it accesses the same variable again. Why doesn't it warn there? And why is 'user' not a char * to begin with? :) -Dimitry --Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlQpPhMACgkQsF6jCi4glqMoYgCglBL1qvCzvB7RQrk6+TeQPD5X QmYAoNqkqv091P3gB46nRccVyKQZ9EDh =oeTD -----END PGP SIGNATURE----- --Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A31E0109-A986-451F-8472-D548868AD4AD>