Date: Mon, 15 Mar 2010 11:52:38 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: phk@FreeBSD.org, freebsd-geom@FreeBSD.org Subject: Re: Escape unsafe characters for kern.geom.confxml XML dump Message-ID: <20100315105238.GB3103@garage.freebsd.pl> In-Reply-To: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi> References: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
--BwCQnh7xodEAoBMC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 13, 2010 at 10:35:52AM +0200, Jaakko Heinonen wrote: >=20 > Hi, >=20 > I intend to commit following patch unless there are objections. I have > seen the problem commonly reported by FreeBSD users. >=20 > --- >=20 > Escape characters unsafe for XML output in GEOM class, instance and provi= der > names. >=20 > - Characters in range 0x01-0x1f except '\t', '\n', and '\r' are replaced > with '?'. Those characters are disallowed in XML. > - '&', '<', '>', '\'', '"' and characters in range 0x7f-0xff are replaced > with XML numeric character reference. >=20 > If the kern.geom.confxml sysctl provides invalid XML, libgeom > geom_xml2tree() fails and utilities using it do not work. Unsafe > characters are common in msdosfs and cd9660 labels. >=20 > PR: kern/104389 > Submitter by: Doug Steinwand (original version) Patch looks good and it was something missing for a very long time. Thanks for taking care of this. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --BwCQnh7xodEAoBMC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkueEXYACgkQForvXbEpPzSSaQCfeAQqgpMMJgAzkcp6A26L1/hC QBgAoKxG6UlrBrpnGYQB8snl5mAxaVtI =qDvd -----END PGP SIGNATURE----- --BwCQnh7xodEAoBMC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100315105238.GB3103>