Date: Sat, 06 Nov 2010 18:03:39 +0300 From: Anonymous <swell.k@gmail.com> To: gljennjohn@googlemail.com Cc: Baptiste Daroussin <bapt@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: [PATCH] update to the latest libedit version and remove libreadline deps Message-ID: <86vd4ao5o4.fsf@gmail.com> In-Reply-To: <20101106120752.001e92c0@ernst.jennejohn.org> (Gary Jennejohn's message of "Sat, 6 Nov 2010 12:07:52 %2B0100") References: <AANLkTi=vxnbFvJabRYLKXG1zA5ry=Phh7y%2Bkg7wjvFmr@mail.gmail.com> <AANLkTimK=YK6Lnt%2BPzpOdQzLz6kCOHqJY6x%2BGiSh2D9z@mail.gmail.com> <20101106120752.001e92c0@ernst.jennejohn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gary Jennejohn <gljennjohn@googlemail.com> writes: > On Fri, 5 Nov 2010 16:58:55 +0100 > Baptiste Daroussin <bapt@freebsd.org> wrote: >> I've updated libedit to the latest version available in the netbsd cvs. >> UTF8 support is disabled for now has it seems to be experimental and segfault. >> I also patch and tested all the sources that used to be linked against >> libreadline so that it now uses libedit making libreadline unused (I >> guess, perhaps I have missed some) >> >> beware that there are collision between libreadline and libedit >> (/usr/include/readline/readline.h) is provided by both of them. >> >> You can find the patch against current here: >> http://people.freebsd.org/~bapt/update-libedit.patch >> > > contrib/wpa/wpa_supplicant/wpa_cli.c, lib/libdisk/tst01.c and > sbin/gvinum/gvinum.c include stuff from readline. > > These are all still in SVN. I think all those hunks in the patch removing <readline/history.h> are unnecessary. On NetBSD history.h is a symlink to readline.h according to libedit/readline/Makefile: INCS= readline.h INCSYMLINKS= readline.h ${INCSDIR}/history.h So, try to replace INCSYMLINKS with INCSLINKS.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vd4ao5o4.fsf>