Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Mar 2013 22:25:46 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Pawel Pekala <pawel@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r314113 - in head/games: . hitori
Message-ID:  <20130313212546.GC53963@ithaqua.etoilebsd.net>
In-Reply-To: <201303132120.r2DLKj9A082447@svn.freebsd.org>
References:  <201303132120.r2DLKj9A082447@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--RIYY1s2vRbPFwWeW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2013 at 09:20:45PM +0000, Pawel Pekala wrote:
> Author: pawel
> Date: Wed Mar 13 21:20:44 2013
> New Revision: 314113
> URL: http://svnweb.freebsd.org/changeset/ports/314113
>=20
> Log:
>   Hitori is a small application written to allow one to play the eponymous
>   puzzle game, which is similar in theme to more popular puzzles such as =
Sudoku
>   created by Nikoli.
>  =20
>   WWW: https://live.gnome.org/Hitori
>  =20
>   PR:		ports/171323
>   Submitted by:	nemysis@gmx.ch
>=20
> Added:
>   head/games/hitori/
>   head/games/hitori/Makefile   (contents, props changed)
>   head/games/hitori/distinfo   (contents, props changed)
>   head/games/hitori/pkg-descr   (contents, props changed)
>   head/games/hitori/pkg-plist   (contents, props changed)
> Modified:
>   head/games/Makefile
>=20
> Modified: head/games/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/games/Makefile	Wed Mar 13 20:54:33 2013	(r314112)
> +++ head/games/Makefile	Wed Mar 13 21:20:44 2013	(r314113)
> @@ -385,6 +385,7 @@
>      SUBDIR +=3D hexxagon
>      SUBDIR +=3D highmoon
>      SUBDIR +=3D hinversi
> +    SUBDIR +=3D hitori
>      SUBDIR +=3D hllib
>      SUBDIR +=3D hlstats
>      SUBDIR +=3D hlstatsx
>=20
> Added: head/games/hitori/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/games/hitori/Makefile	Wed Mar 13 21:20:44 2013	(r314113)
> @@ -0,0 +1,59 @@
> +# Created by: nemysis@gmx.ch
> +# $FreeBSD$
> +
> +PORTNAME=3D	hitori
> +PORTVERSION=3D	0.3.2
> +CATEGORIES=3D	games
> +MASTER_SITES=3D	GNOME
> +EXTRACT_SUFX=3D	.tar.xz
> +
> +MAINTAINER=3D	nemysis@gmx.ch
> +COMMENT=3D	Logic game similar to Sudoku
> +
> +LICENSE=3D	GPLv3 CCbyNCSA3
> +LICENSE_COMB=3D	dual
> +LICENSE_NAME_CCbyNCSA3=3D	Attribution-NonCommercial-ShareAlike 3.0 Unpor=
ted
> +LICENSE_FILE_CCbyNCSA3=3D	${WRKSRC}/COPYING-DOCS
> +LICENSE_PERMS_CCbyNCSA3=3Ddist-mirror pkg-mirror auto-accept
> +
> +BUILD_DEPENDS=3D	xml2po:${PORTSDIR}/textproc/gnome-doc-utils
> +LIB_DEPENDS=3D	cairo:${PORTSDIR}/graphics/cairo
> +
> +GNU_CONFIGURE=3D	yes
> +USE_GMAKE=3D	yes
> +USE_GNOME=3D	glib20 gtk30
> +MAKE_JOBS_SAFE=3D	yes
> +INSTALLS_ICONS=3D	yes
> +
> +PORTDOCS=3D	AUTHORS ChangeLog MAINTAINERS NEWS README
> +
> +.include <bsd.port.options.mk>
> +
> +.if ${PORT_OPTIONS:MNLS}
> +USE_GETTEXT=3D	yes
> +PLIST_SUB+=3D	NLS=3D""
> +.else
> +CONFIGURE_ARGS+=3D	--disable-nls
> +PLIST_SUB+=3D	NLS=3D"@comment "
> +.endif
> +
> +post-patch:
> +.if ${PORT_OPTIONS:MNLS}
> +	@${REINPLACE_CMD} -e 's|itlocaledir =3D $$(prefix)/$$(DATADIRNAME)/loca=
le|itlocaledir =3D $$(prefix)/share/locale|' \
> +		${WRKSRC}/po/Makefile.in.in
> +.endif
> +
> +post-install:
> +	${INSTALL_DATA} ${WRKSRC}/data/icons/48x48/${PORTNAME}.png ${PREFIX}/sh=
are/pixmaps/${PORTNAME}.png
> +
> +.if ${PORT_OPTIONS:MDOCS}
> +	${MKDIR} ${DOCSDIR}
> +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
> +.endif
> +
> +.if ${OSVERSION} < 800505 || (${OSVERSION} >=3D 900000 && ${OSVERSION} <=
 900012)
> +USE_XZ=3D		yes
> +EXTRACT_DEPENDS+=3D	lzma:${PORTSDIR}/archivers/xz
> +.endif

beside the unusual ordering of the Makefile, this seems a duplicate of USE_=
XZ,
why doing so?

regards,
Bapt

--RIYY1s2vRbPFwWeW
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlFA7toACgkQ8kTtMUmk6Ey1XACfSjR7PX7GuhElZ0b5gVAYfpBR
+y0AnAuCWJiny26ytTIkWU3S4yKe9RGV
=toIf
-----END PGP SIGNATURE-----

--RIYY1s2vRbPFwWeW--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130313212546.GC53963>