Date: Thu, 18 Jan 2007 18:52:16 GMT From: Robert Gogolok<gogo@cs.uni-sb.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/108103: [print/hplip] wrong usage of options Message-ID: <200701181852.l0IIqGUi076011@www.freebsd.org> Resent-Message-ID: <200701181900.l0IJ0fjd057298@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 108103 >Category: ports >Synopsis: [print/hplip] wrong usage of options >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jan 18 19:00:41 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Robert Gogolok >Release: FreeBSD 6.1 >Organization: http://www.robert-gogolok.de >Environment: FreeBSD desktop.gogolok.de 6.1-SECURITY FreeBSD 6.1-SECURITY #0: Mon Dec 4 07:53:55 UTC 2006 root@builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: If e.g. PACKAGE_BUILDING is defined, you will not be able to build print/hplip without x11-toolkits/py-qt . quote from the porters handbook: "Due to a deficiency in the infrastructure, you can only test WITH_* variables for options which are OFF by default, and WITHOUT_* variables for options which default to ON." So test for WITHOUT_GUI and not for WITH_GUI in the hplip Makefile. >How-To-Repeat: Set PACKAGE_BUILDING=yes and try now to build print/hplip without x11-toolkits/py-qt. >Fix: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/print/hplip/Makefile,v retrieving revision 1.7 diff -u -r1.7 Makefile --- Makefile 27 Sep 2006 23:00:09 -0000 1.7 +++ Makefile 18 Jan 2007 18:33:42 -0000 @@ -52,7 +52,7 @@ WITH_GUI= yes .endif -.if defined(WITH_GUI) +.if !defined(WITHOUT_GUI) RUN_DEPENDS+= pylupdate:${PORTSDIR}/x11-toolkits/py-qt .endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701181852.l0IIqGUi076011>