Date: Mon, 11 Oct 2010 10:23:26 -0400 From: John Baldwin <jhb@freebsd.org> To: Ivan Voras <ivoras@freebsd.org> Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" <ae@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213662 - in head: sbin/geom/class/concat sbin/geom/class/eli sbin/geom/class/journal sbin/geom/class/mirror sbin/geom/class/part sbin/geom/class/raid3 sbin/geom/class/shsec sbin/geom/c... Message-ID: <201010111023.26220.jhb@freebsd.org> In-Reply-To: <AANLkTikqYJ=t9mMcHAU3Si8wx08m=RxiBgBgUjLfyzGX@mail.gmail.com> References: <201010092020.o99KKSYW051470@svn.freebsd.org> <AANLkTikqYJ=t9mMcHAU3Si8wx08m=RxiBgBgUjLfyzGX@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, October 10, 2010 4:54:37 am Ivan Voras wrote: > On 9 October 2010 22:20, Andrey V. Elsukov <ae@freebsd.org> wrote: > > Author: ae > > Date: Sat Oct 9 20:20:27 2010 > > New Revision: 213662 > > URL: http://svn.freebsd.org/changeset/base/213662 > > > > Log: > > Replace strlen(_PATH_DEV) with sizeof(_PATH_DEV) - 1. > > Um, this looks like a pointless change and for the worse; Even at -O1 > the compiler will reduce strlen(constant) to just its result and for > code like printf("%d\n", sizeof("1234567")) produce code like: > > movl $7, %esi > movl $.LC0, %edi > movl $0, %eax > call printf > > And (though tastes differ) I think the sizeof() variant is less > readable. The strlen(_PATH_something) idiom is common in other parts > of the kernel outside GEOM. > > In short - why was this done? I agree, strlen("foo") is much clearer. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010111023.26220.jhb>