Date: Wed, 31 Dec 2003 09:22:14 -0500 (EST) From: Daniel Eischen <eischen@vigrid.com> To: Marc Olzheim <marcolz@stack.nl> Cc: hackers@freebsd.org Subject: Re: libc_r/uthread/uthread_join.c Message-ID: <Pine.GSO.4.10.10312310911360.3264-100000@pcnet5.pcnet.com> In-Reply-To: <20031231140533.GA56158@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 31 Dec 2003, Marc Olzheim wrote: > On Wed, Dec 31, 2003 at 08:47:03AM -0500, Daniel Eischen wrote: > > > Is there a reason why in the case that a thread is not done yet, > > > pthread_join() does not call _thread_kern_sig_undefer() ? > > > [snip] > > > > No, it looks like you found a bug. Committed, thanks! > > Hmm, ok ;-) But then why is _thread_kern_sig_undefer() called within > every if-case, instead of just below the if ? It looked like it was > contructed this way to be able to omit _thread_kern_sig_undefer() in > that specific case... ;-) Look at revision 1.16 of uthread_join. Revision 1.17 removed the _thread_kern_sig_[un]defer()'s and revision 1.18 put them back in but left an undefer. -- Dan Eischen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.10.10312310911360.3264-100000>