Date: Thu, 27 Nov 2014 08:26:40 +0100 From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= <eri@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274709 - head/sys/netpfil/pf Message-ID: <CAPBZQG3rOd43MEuSzvJfHCY=MDoTLy1VQ-2Juf-5zy7w%2BS24rg@mail.gmail.com> In-Reply-To: <861torxt7j.fsf@nine.des.no> References: <201411191331.sAJDV9bH092190@svn.freebsd.org> <86tx1nvcy4.fsf@nine.des.no> <86ppcbvb04.fsf@nine.des.no> <86ioi3y0gb.fsf@nine.des.no> <CAPBZQG3i2h-wUQa16d0gt%2BfpsfNEBHgZsvtryvnwtrPVZsw8YA@mail.gmail.com> <861torxt7j.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 25, 2014 at 3:14 PM, Dag-Erling Sm=C3=B8rgrav <des@des.no> wrot=
e:
> Ermal Lu=C3=A7i <eri@freebsd.org> writes:
> > Also this only affects the traffic sourced by the host itself and not
> > forwarded traffic and I think this patch will provide a regression for
> > the issues that the committed patch does.
>
> How?
>
The code as it stands (after your commit) is incorrect and will trigger
> an assertion in vtnet(4). You could argue that it is less incorrect
> than the original, but the cure is worse than the disease.
>
>
Let me come back to you in the following days with a better analysis.
The existing sate of the world i think there will be checksum issues again
especially in policy routing situations.
I will come back with another patch to solve this, but am busy with some
${WORK} tasks.
> My patch fixes the panic as well as two preexisting bugs (not taking the
> IP checksum into account in the IPv4 path, and ignoring hardware
> offloading). See https://bugs.freebsd.org/192013#c10 for an explanation
> of what it does and why.
>
> DES
> --
> Dag-Erling Sm=C3=B8rgrav - des@des.no
>
--=20
Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPBZQG3rOd43MEuSzvJfHCY=MDoTLy1VQ-2Juf-5zy7w%2BS24rg>