Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Dec 2006 14:03:57 +0100
From:      Ruben van Staveren <ruben@verweg.com>
To:        Pav Lucistnik <pav@FreeBSD.org>
Cc:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/106203: linux-megacli needs unzip as a build dependancy too
Message-ID:  <20061203130357.GA7338@helium.verweg.com>
In-Reply-To: <200612021212.kB2CCYUL018259@freefall.freebsd.org>
References:  <200612021212.kB2CCYUL018259@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 02, 2006 at 12:12:34PM +0000, Pav Lucistnik wrote:
> Synopsis: linux-megacli needs unzip as a build dependancy too
> 
> State-Changed-From-To: open->closed
> State-Changed-By: pav
> State-Changed-When: Sat Dec 2 12:10:40 UTC 2006
> State-Changed-Why: 
> Committed, thanks. I also added rpm2cpio as another build dependency, as I see
> you use it in do-build: target too.
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=106203

In light of Kris Kennaway's reply, maybe better have it like this.
We can do it either now, or in the next version of megacli.

Regards,
	Ruben



--- Makefile.orig	Sun Dec  3 12:41:31 2006
+++ Makefile	Sun Dec  3 12:42:22 2006
@@ -15,8 +15,6 @@
 MAINTAINER=		ruben@verweg.com
 COMMENT=		LSI MegaRAID SAS controller management utility
 
-BUILD_DEPENDS+=       unzip:${PORTSDIR}/archivers/unzip
-
 NO_WRKSUBDIR=		yes
 USE_ZIP=		yes
 RESTRICTED=		Redistribution prohibited, see: http://lsi.com/cm/License.do
@@ -28,10 +26,12 @@
 RPM2CPIO?=			${LOCALBASE}/bin/rpm2cpio
 EXTRACT_DEPENDS+=		${RPM2CPIO}:${PORTSDIR}/archivers/rpm
 
-do-build:
+post-extract:
 	@cd ${WRKSRC} && \
 		${UNZIP_CMD} MegaCliLin.zip && \
 		${RPM2CPIO} MegaCli-${PORTVERSION}-0.i386.rpm | ${CPIO} -id --quiet
+
+do-build:
 	@${BRANDELF} -t Linux ${WRKSRC}/usr/sbin/MegaCli
 
 do-install:




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061203130357.GA7338>