Date: Wed, 10 Dec 2014 15:58:35 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r374466 - head/Mk Message-ID: <20141210155835.GA31017@FreeBSD.org> In-Reply-To: <06A4A7BDAD61A31C6EE5D912@ogg.in.absolight.net> References: <201412101510.sBAFAeLg034594@svn.freebsd.org> <20141210151952.GA16023@FreeBSD.org> <06A4A7BDAD61A31C6EE5D912@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 10, 2014 at 04:54:18PM +0100, Mathieu Arnold wrote: > +--On 10 d'ecembre 2014 15:19:52 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> > wrote: > | On Wed, Dec 10, 2014 at 03:10:40PM +0000, Mathieu Arnold wrote: > |> New Revision: 374466 > |> URL: https://svnweb.freebsd.org/changeset/ports/374466 > |> QAT: https://qat.redports.org/buildarchive/r374466/ > |> > |> Log: > |> Patches go into PATCHDIR, not FILESDIR. > |> > |> Pointy hat to: Everybody that looked at the code review, me included. > | > | Not really; I recall there was an idea to get rid of PATCHDIR altogether, > | it's more of a relic these days. FILESDIR works equally well and makes > | more sense (i.e. there is "files" directory and no "patches"). > > Maybe, but then, someone has to remove all of PATCHDIR, because before this > fix, the framework would look at the patches in PATCHDIR, and save them in > FILESDIR. Basically, yes, since vast majority of ports assumes that PATCHDIR == FILESDIR (and it is true by default), it should be fairly easy to fix the edge cases and remove PATCHDIR. Sounds like a good idea for a Phabricator issue. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141210155835.GA31017>