Date: Sat, 25 Nov 2006 20:30:46 +0100 (CET) From: Ulrich Spoerlein <uspoerlein@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: cid_kewpie@users.sourceforge.net, pav@FreeBSD.org Subject: ports/105847: [PATCH] multimedia/lsdvd: Fix segfault / make usable for dvd::rip Message-ID: <200611251930.kAPJUkXt009758@roadrunner.q.local> Resent-Message-ID: <200611251940.kAPJeBU4046672@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 105847
>Category: ports
>Synopsis: [PATCH] multimedia/lsdvd: Fix segfault / make usable for dvd::rip
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Nov 25 19:40:10 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Ulrich Spoerlein
>Release: FreeBSD 6.2-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD roadrunner 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #1: Thu Oct 26 18:55:18 CEST 2006
>Description:
The "code output" subroutine handling arrays is flawed. It will segfault upon
first call. The following patch to ocode.c fixes this (at least, it is running
stable now and dvd::rip is happy with the output).
I included the original author, because this fix should be comitted upstream
too. Thanks!
Added file(s):
- files/patch-ocode.c
Port maintainer (pav@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- lsdvd-0.16.patch begins here ---
Index: files/patch-ocode.c
===================================================================
RCS file: files/patch-ocode.c
diff -N files/patch-ocode.c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ files/patch-ocode.c 25 Nov 2006 19:27:04 -0000
@@ -0,0 +1,12 @@
+--- ocode.c.orig Sat Nov 25 19:46:18 2006
++++ ocode.c Sat Nov 25 19:45:59 2006
+@@ -114,8 +114,7 @@
+ INDENT;
+ if (_lvl) {
+ printf(syntax->array_inner, name);
+- printf(_lvl_return[_lvl]);
+- //sprintf(_lvl_return[_lvl], syntax->return_array_inner, name);
++ _lvl_return[_lvl] = syntax->return_array_inner;
+ } else {
+ printf(syntax->array_outer, name);
+ _lvl_return[_lvl] = syntax->return_array_outer;
--- lsdvd-0.16.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611251930.kAPJUkXt009758>