Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 May 2000 22:44:26 -0700
From:      "Andrey A. Chernov" <ache@freebsd.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        current@freebsd.org, jdp@freebsd.org
Subject:   Re: cvs commit: src/contrib/ncurses/include curses.h.in src/contrib/ncurses/ncurses/trace lib_trace.c
Message-ID:  <20000523224425.B26457@freebsd.org>
In-Reply-To: <Pine.BSF.4.21.0005241407520.1841-100000@besplex.bde.org>; from bde@zeta.org.au on Wed, May 24, 2000 at 02:09:24PM %2B1000
References:  <20000523085737.A27646@freebsd.org> <Pine.BSF.4.21.0005241407520.1841-100000@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 24, 2000 at 02:09:24PM +1000, Bruce Evans wrote:
> > Previously it breaks system's /bin/sh so sh's trace() was wrongly renamed to 
> > sh_trace() instead of fixing ncurses.
> 
> FYI, it may also break ftp, but the problem is only visible when ftp is linked
> static, due to the problem with dynamic linkage in ld:
> 
>     /usr/src/usr.bin/ftp/cmds.c:906: warning: initialization makes integer from pointer without a cast
>     /usr/libexec/elf/ld: Warning: size of symbol `trace' changed from 4 to 5 in lib_trace.o
>     /usr/libexec/elf/ld: Warning: type of symbol `trace' changed from 1 to 
2 in lib_trace.o

Yes, this bug is very dangerous and many places are affected so I fix 
it immediately.

The fact our ld can't detect multiply definitions when linking shared is 
another issue - I recently send this to -current, but still got no reaction.

-- 
Andrey A. Chernov
<ache@nagual.pp.ru>
http://nagual.pp.ru/~ache/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000523224425.B26457>