Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Mar 2001 00:59:19 -0600
From:      "Michael C . Wu" <keichii@iteration.net>
To:        MINOURA Makoto <minoura@netbsd.org>
Cc:        current@freebsd.org, i18n@freebsd.org, thinker@branda.to
Subject:   Re: Request for review [Re: /bin/ls patch round #2]
Message-ID:  <20010320005919.B46871@peorth.iteration.net>
In-Reply-To: <20010320065321.E63933668@203.141.142.186.user.am.il24.net>; from minoura@netbsd.org on Tue, Mar 20, 2001 at 03:53:21PM %2B0900
References:  <20010319195438.A43266@peorth.iteration.net> <20010320002043.A46115@peorth.iteration.net> <20010320065321.E63933668@203.141.142.186.user.am.il24.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 20, 2001 at 03:53:21PM +0900, MINOURA Makoto scribbled:
| 
| |> In <20010320002043.A46115@peorth.iteration.net>
| |>  "Michael C . Wu" <keichii@iteration.net> wrote:
| 
| > Please review this patch and comment on it.  I plan to commit
| > this in a few days if there are no more objections.
| 
| OBJECTION.

Please do not type in all capitals.  

| In general direct manipulation of rune is evil.
| It is an internal data structure in libc; using it from
| ordinary applications breaks portability and is not

portability to what?  We import colorls from outside,
and I do not know what you want to "port" to that this
would not work on.

| future-proof (in case we'd overhaul the locale
| implementation).
| 
| Actually NetBSD does not export <rune.h>.

So, will you please tell me how to solve this without
having me rewrite libc?

We could always have a ports/xxxx/colorls.......Oh wait,
we can just use gnuls.
-- 
+-----------------------------------------------------------+
| keichii@iteration.net         | keichii@freebsd.org       |
| http://iteration.net/~keichii | Yes, BSD is a conspiracy. |
+-----------------------------------------------------------+

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010320005919.B46871>