Date: Fri, 29 Apr 2011 23:23:06 +0200 From: Juergen Lock <nox@jelal.kn-bremen.de> To: Andriy Gapon <avg@FreeBSD.org> Cc: netchild@FreeBSD.org, emulation@FreeBSD.org, Juergen Lock <nox@jelal.kn-bremen.de>, HASHI Hiroaki <hashiz@meridiani.jp>, multimedia@FreeBSD.org, Alexander Leidinger <Alexander@Leidinger.net>, Ion-Mihai Tetcu <itetcu@FreeBSD.org>, fluffy@FreeBSD.org Subject: Re: audio/linux-f10-alsa-plugins-oss Message-ID: <20110429212306.GA43822@triton8.kn-bremen.de> In-Reply-To: <4DBA4F77.1000409@FreeBSD.org> References: <4DB72341.7060201@FreeBSD.org> <20110426202349.GA14855@triton8.kn-bremen.de> <4DB7BC6A.7060207@FreeBSD.org> <20110427163047.GA47520@triton8.kn-bremen.de> <7d7a2fab-7c4e-44ce-bdf2-93811c40a4fe@email.android.com> <20110428193351.GA8814@triton8.kn-bremen.de> <68864477@h30.sp.ipt.ru> <20110428220114.00004b22@unknown> <20110428201939.GA16556@triton8.kn-bremen.de> <4DBA4F77.1000409@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 29, 2011 at 08:41:11AM +0300, Andriy Gapon wrote:
>
> There is another thing that I've just noticed - wouldn't the port overwrite a
> custom pcm-oss.conf (if any)?
>
That is true... I guess I didn't stumble across this because I
edited the /compat/linux/etc/asound.conf similar to the one below
/usr/local/etc instead of editing the pcm-oss.conf this port installs.
> I think it would be nice to do the usual .conf-dist vs .conf dance here.
> E.g. something like:
> CONF_FILE= etc/alsa/pcm/pcm-oss.conf
>
> post-patch:
> @${RM} ${WRKDIR}/${CONF_FILE}.orig
> @${MV} ${WRKDIR}/${CONF_FILE} ${WRKDIR}/${CONF_FILE}-dist
>
> post-install:
> @if [ ! -f ${PREFIX}/${CONF_FILE} ]; then \
> ${CP} -p ${PREFIX}/${CONF_FILE}-dist ${PREFIX}/${CONF_FILE} ; \
> fi
> PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
>
>
> And in pkg-plist:
> @unexec if cmp -s %D/etc/alsa/pcm/pcm-oss.conf-dist
> %D/etc/alsa/pcm/pcm-oss.conf; then rm -f %D/etc/alsa/pcm/pcm-oss.conf; fi
> etc/alsa/pcm/pcm-oss.conf-dist
> @exec if [ ! -f %D/etc/alsa/pcm/pcm-oss.conf ] ; then cp -p %D/%F %B/client.conf; fi
>
>
> What do you think?
I think now that the port is committed it's the maintainer's call,
so I Cc'd him. :)
Thanx,
Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110429212306.GA43822>