Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Dec 2010 14:26:48 GMT
From:      Aldis Berjoza <aldis@bsdroot.lv>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/153248: [PATCH] lang/fasm unbreak on amd64 and ia64 after last commit
Message-ID:  <201012171426.oBHEQmJ3064665@red.freebsd.org>
Resent-Message-ID: <201012171430.oBHEUC1u092568@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         153248
>Category:       ports
>Synopsis:       [PATCH] lang/fasm unbreak on amd64 and ia64 after last commit
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 17 14:30:11 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Aldis Berjoza
>Release:        
>Organization:
>Environment:
FreeBSD desktop.pc 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
After update to v1.17 of Makefile I couldn't build fasm on my amd64 box.
I couldn't figure out why exactly it didn't work, because I do have /usr/lib32

Anyway I looked at bsd.port.mk and saw IA32_BINARY_PORT variable, so I modified port to use this variable and now it builds on amd64 again.

This also simplified Makefile a little :)
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -u fasm.bak/Makefile fasm/Makefile
--- fasm.bak/Makefile	2010-12-17 15:56:39.857949624 +0200
+++ fasm/Makefile	2010-12-17 16:21:33.546591171 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	fasm
 PORTVERSION=	1.69.29
+PORTREVISION=	1
 CATEGORIES=	lang devel
 MASTER_SITES=	http://flatassembler.net/
 
@@ -14,17 +15,14 @@
 COMMENT=	Flat, multiple-pass assembler for IA-32 & x86-64 architectures
 
 ONLY_FOR_ARCHS=	i386 amd64 ia64
+IA32_BINARY_PORT=YES
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} != "i386"
-.if defined(HAVE_COMPAT_IA32_LIBS)
 CFLAGS=		-m32 -L/usr/lib32 -B/usr/lib32
-.else
-IGNORE=		requires 32-bit libraries installed under /usr/lib32
-.endif
 .endif
 
 do-build:


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012171426.oBHEQmJ3064665>