Date: Wed, 25 Nov 2009 08:14:35 +1100 From: Mark Andrews <marka@isc.org> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: FreeBSD Stable <freebsd-stable@freebsd.org> Subject: Re: pthread.h: typo in #define pthread_cleanup_push/pthread_cleanup_pop Message-ID: <200911242114.nAOLEZIN049990@drugs.dv.isc.org> In-Reply-To: Your message of "Tue, 24 Nov 2009 16:53:35 %2B0200." <86aayc7z4g.fsf@zhuzha.ua1> References: <86aayc7z4g.fsf@zhuzha.ua1>
next in thread | previous in thread | raw e-mail | index | archive | help
Report it using "send-pr". That way the problem will make its way into the bug tracking system. In message <86aayc7z4g.fsf@zhuzha.ua1>, Mikolaj Golub writes: > Hi, > > I have problems with compiling our application under 8.0. > > It fails due to these definitions in pthread.h that look like a typo or > incorrectly applied patch: > > 170 #define pthread_cleanup_push(cleanup_routine, cleanup_arg) > \ > 171 { > \ > 172 struct _pthread_cleanup_info __cleanup_info__; > \ > 173 __pthread_cleanup_push_imp(cleanup_routine, clean > up_arg,\ > 174 &__cleanup_info__); > \ > 175 { > 176 > 177 #define pthread_cleanup_pop(execute) > \ > 178 } > \ > 179 __pthread_cleanup_pop_imp(execute); > \ > 180 } > > > This patch fixes the problem for me: > > --- pthread.h.orig 2009-11-24 16:44:13.000000000 +0200 > +++ pthread.h 2009-11-24 16:44:45.000000000 +0200 > @@ -172,10 +172,10 @@ > struct _pthread_cleanup_info __cleanup_info__; \ > __pthread_cleanup_push_imp(cleanup_routine, cleanup_arg,\ > &__cleanup_info__); \ > - { > + } > > #define pthread_cleanup_pop(execute) > \ > - } \ > + { \ > __pthread_cleanup_pop_imp(execute); \ > } > > -- > Mikolaj Golub > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911242114.nAOLEZIN049990>