Date: Fri, 17 Aug 2001 14:27:43 +0300 From: Juha-Matti Liukkonen <jml@cubical.fi> To: hm@hcs.de Cc: freebsd-isdn@freebsd.org Subject: Heinous bug in i4b CAPI support Message-ID: <3B7CFFAF.4A37B960@cubical.fi>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------A0277CEA452086267319D5BF
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi,
it seems that I slipped a nasty bug into the CAPI support. The message
lengths for CONNECT_REQ and CONNECT_IND are incorrect, which causes
dialouts to fail after certain error situations (an invalid -- not
wrong! -- number has been dialed). Since these messages are tagged as
too short, the device reads trailing garbage as the B protocol
parameters; this is OK as long as the garbage consists of zero bytes,
which it usually does, except after the said error.
Another change we have taken into use is to send an explicit Q.850
"normal call clearing" code when a call is ignored using PRI equipment
(specifically AVM T1); the CAPI pseudo-code for ignore, 1, translates
into something at least Ericsson exchanges interpret oddly (message
"this area is not reachable from your number"). NCCLR makes the exchange
give a busy signal, which is the behaviour at least we prefer
(conceivably, the ignore code could be made a sysctl variable).
The attached patch corrects the message length issue. It also includes a
somewhat unpretty solution for the PRI ignore code (if device's number
of channels equals 30, assume PRI and send NCCLR, otherwise send CAPI
ignore). Tested using AVM B1 PCI and T1 PCI.
Cheers,
- Juha
--
Juha-Matti Liukkonen, Cubical Solutions Ltd
Phone: +358(0)405280142
Email: jml@cubical.fi
--------------A0277CEA452086267319D5BF
Content-Type: text/plain; charset=us-ascii;
name="i4b-101_capifix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="i4b-101_capifix.patch"
--- capi_msgs.c-orig Tue Aug 14 18:39:59 2001
+++ capi_msgs.c Fri Aug 17 14:13:41 2001
@@ -195,7 +195,7 @@
int slen = strlen(cd->src_telno);
int dlen = strlen(cd->dst_telno);
- m = i4b_Dgetmbuf(8 + 18 + slen + dlen);
+ m = i4b_Dgetmbuf(8 + 27 + slen + dlen);
if (!m) {
printf("capi%d: can't get mbuf for connect_req\n", sc->sc_unit);
return;
@@ -566,7 +566,7 @@
u_int32_t PLCI;
int dlen = strlen(cd->dst_telno);
- m = i4b_Dgetmbuf(8 + 11 + dlen);
+ m = i4b_Dgetmbuf(8 + 21 + dlen);
if (!m) {
printf("capi%d: can't get mbuf for connect_resp\n", sc->sc_unit);
return;
@@ -600,7 +600,12 @@
case SETUP_RESP_DNTCRE:
sc->sc_bchan[cd->channelid].state = B_FREE;
ctrl_desc[sc->ctrl_unit].bch_state[cd->channelid] = BCH_ST_FREE;
- msg = capimsg_setu16(msg, 1); /* Ignore */
+ if (sc->sc_nbch == 30) {
+ /* With PRI, we can't really ignore calls -- normal clearing */
+ msg = capimsg_setu16(msg, (0x3480|CAUSE_Q850_NCCLR));
+ } else {
+ msg = capimsg_setu16(msg, 1); /* Ignore */
+ }
break;
default:
@@ -733,7 +738,7 @@
void capi_data_b3_ind(capi_softc_t *sc, struct mbuf *m_in)
{
- struct mbuf *m = i4b_Dgetmbuf(8 + 14);
+ struct mbuf *m = i4b_Dgetmbuf(8 + 6);
u_int8_t *msg = mtod(m_in, u_int8_t*);
u_int16_t applid, msgid;
u_int32_t NCCI;
--------------A0277CEA452086267319D5BF--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-isdn" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B7CFFAF.4A37B960>