Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Feb 2003 00:39:32 -0600
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Alfred Perlstein <bright@mu.org>
Cc:        David O'Brien <obrien@FreeBSD.org>, Chad David <davidc@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, legacy-committers@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/yacc skeleton.c
Message-ID:  <20030208003932.A47205@FreeBSD.org>
In-Reply-To: <20030208063406.GG88781@elvis.mu.org>; from bright@mu.org on Fri, Feb 07, 2003 at 10:34:06PM -0800
References:  <200302070339.h173dRvU071460@repoman.freebsd.org> <20030208062131.GA7362@dragon.nuxi.com> <20030208063406.GG88781@elvis.mu.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* De: Alfred Perlstein <bright@mu.org> [ Data: 2003-02-08 ]
	[ Subjecte: Re: cvs commit: src/usr.bin/yacc skeleton.c ]
> * David O'Brien <obrien@FreeBSD.org> [030207 22:23] wrote:
> > On Thu, Feb 06, 2003 at 07:39:27PM -0800, Chad David wrote:
> > > davidc      2003/02/06 19:39:27 PST
> > > 
> > >   Modified files:
> > >     usr.bin/yacc         skeleton.c 
> > >   Log:
> > >   Add __unused to the declaration of yyrcsid.
> > >   
> > >   Revision  Changes    Path
> > >   1.35      +2 -1      src/usr.bin/yacc/skeleton.c
> > > http://cvsweb.freebsd.org/src/usr.bin/yacc/skeleton.c.diff?r1=1.34&r2=1.35
> > 
> > Please back this out.  Non-portable parsers are now produced.  Not every
> > OS has <sys/cdefs.h>, nor do they understand "__unused".
> 
> How about taking the time to offer advice that will gain us forward
> progress?  Chad wants to get rid of warnings from the code produced,
> perhaps if he added #ifdef __FreeBSD__ or something to the generated
> output?

There is already a check for lint.  I suggested to Chad initially that
maybe a tunable for YYWANTRCSID or something would do the job, after
all, not everyone cares.  But, anyway.
-- 
Juli Mallett <jmallett@FreeBSD.org>
AIM: BSDFlata -- IRC: juli on EFnet
OpenDarwin, Mono, FreeBSD Developer
ircd-hybrid Developer, EFnet addict
FreeBSD on MIPS-Anything on FreeBSD

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030208003932.A47205>