Date: Mon, 14 Oct 2002 11:11:11 +0200 From: Thomas Quinot <thomas@cuivre.fr.eu.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: "Crist J. Clark" <crist.clark@attbi.com>, Trish Lynch <trish@bsdunix.net>, Adrian Wontroba <aw1@stade.co.uk>, chris scott <c.scott@uk.tiscali.com>, freebsd-stable@FreeBSD.ORG Subject: Re: Patch #2 (Re: Ifconfig config of gif tunnels) Message-ID: <20021014091111.GA66883@melusine.cuivre.fr.eu.org> In-Reply-To: <200210140228.g9E2SRlA058696@apollo.backplane.com> References: <20021013172810.A19177@titus.hanley.stade.co.uk> <20021013130138.G523-100000@femme.sapphite.org> <20021013214642.GB90169@blossom.cjclark.org> <200210132154.g9DLsUmc057065@apollo.backplane.com> <20021013225509.GA90575@blossom.cjclark.org> <200210140228.g9E2SRlA058696@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 2002-10-14, Matthew Dillon écrivait :
> Here's a new patch. I attempt to pull out terminal
> parameters via stty.
Should this be committed, it should be *prominently* documented that
there is a very significant change in the user interface: when
mergemaster does not drop you into a more(1) prompt:
- in the current situation, the user is guaranteed that he's seeing
the complete diff on his screen;
- with your patch he might see only a part of that.
So if the user wants to make is merging decision based on the diff, he
cannot do that anymore without additional manual intervention.
Plus, for those who like/are used to the current behaviour, it would be
nice if your change could be tied to a command line switch (I don't mind
for the new behaviour to be the default, but I think the old one should
be left as an option.)
Thomas.
--
Thomas.Quinot@Cuivre.FR.EU.ORG
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021014091111.GA66883>