Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Nov 2009 16:29:33 -0500 (EST)
From:      Daniel Eischen <deischen@freebsd.org>
To:        Mark Andrews <marka@isc.org>
Cc:        FreeBSD Stable <freebsd-stable@freebsd.org>, Mikolaj Golub <to.my.trociny@gmail.com>
Subject:   Re: pthread.h: typo in #define	pthread_cleanup_push/pthread_cleanup_pop
Message-ID:  <Pine.GSO.4.64.0911241628060.5810@sea.ntplx.net>
In-Reply-To: <200911242114.nAOLEZIN049990@drugs.dv.isc.org>
References:  <86aayc7z4g.fsf@zhuzha.ua1> <200911242114.nAOLEZIN049990@drugs.dv.isc.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 25 Nov 2009, Mark Andrews wrote:

>
> Report it using "send-pr".  That way the problem will make its way into the
> bug tracking system.
>
> In message <86aayc7z4g.fsf@zhuzha.ua1>, Mikolaj Golub writes:
>> Hi,
>>
>> I have problems with compiling our application under 8.0.
>>
>> It fails due to these definitions in pthread.h that look like a typo or
>> incorrectly applied patch:

Did someone already reply to this?

I think the problem is in your application.  You cannot
have push and pop at different nesting levels.  The
start brace in the push is ended by the end brace in
pop on purpose.  It is to enforce nesting levels.

>>
>>     170 #define         pthread_cleanup_push(cleanup_routine, cleanup_arg)
>>        \
>>     171                 {
>>        \
>>     172                         struct _pthread_cleanup_info __cleanup_info__;
>>        \
>>     173                         __pthread_cleanup_push_imp(cleanup_routine, clean
>> up_arg,\
>>     174                                 &__cleanup_info__);
>>        \
>>     175                         {
>>     176
>>     177 #define         pthread_cleanup_pop(execute)
>>        \
>>     178                         }
>>        \
>>     179                         __pthread_cleanup_pop_imp(execute);
>>        \
>>     180                 }

-- 
DE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.0911241628060.5810>