Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Oct 2002 13:05:09 -0700 (PDT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 19575 for review
Message-ID:  <200210182005.g9IK59sh079023@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=19575

Change 19575 by rwatson@rwatson_tislabs on 2002/10/18 13:04:55

	Coallesce failure cases.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#93 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#93 (text+ko) ====

@@ -2762,14 +2762,10 @@
 	error = mac_check_vnode_rename_from(td->td_ucred, fromnd.ni_dvp, fvp,
 	    &fromnd.ni_cnd);
 	NDFREE(&fromnd, NDF_ONLY_UNLOCK);
-	if (error) {
-		NDFREE(&fromnd, NDF_ONLY_PNBUF);
-		vrele(fromnd.ni_dvp);
-		vrele(fvp);
-		goto out1;
-	}
 #endif
-	if ((error = vn_start_write(fvp, &mp, V_WAIT | PCATCH)) != 0) {
+	if (error == 0)
+		error = vn_start_write(fvp, &mp, V_WAIT | PCATCH);
+	if (error != 0) {
 		NDFREE(&fromnd, NDF_ONLY_PNBUF);
 		vrele(fromnd.ni_dvp);
 		vrele(fvp);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210182005.g9IK59sh079023>