Date: Tue, 12 Aug 2008 04:19:24 +0300 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Oleksandr Tymoshenko <gonzo@freebsd.org> Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>, arch@freebsd.org Subject: Re: Need a code review Message-ID: <874p5rt4gz.fsf@kobe.laptop> In-Reply-To: <48A084C0.4040105@freebsd.org> (Oleksandr Tymoshenko's message of "Mon, 11 Aug 2008 21:28:16 %2B0300") References: <20080729.161303.709402272.imp@bsdimp.com> <86r69buar0.fsf@ds4.des.no> <489B08F6.8060605@freebsd.org> <867iasfmrh.fsf@ds4.des.no> <489EDD2F.9080302@freebsd.org> <86myjkbnky.fsf@ds4.des.no> <48A084C0.4040105@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 11 Aug 2008 21:28:16 +0300, Oleksandr Tymoshenko <gonzo@freebsd.org= > wrote: > Dag-Erling Sm=F8rgrav wrote: >> Oleksandr Tymoshenko <gonzo@freebsd.org> writes: >>> Here is new fix: http://people.freebsd.org/~gonzo/mips2/libpam2.diff >>> The idea is to set define explicitly for dynamic case rather then rely >>> on __PIC__. >> >> This is completely backwards. Dynamic is the default option, and in >> fact the only supported option on many (non-FreeBSD) systems. If it >> were up to me, I would remove support for statically linked modules >> entirely. > > OK, so the static case is the one to be marked explicitly. Here is the > next patch: http://people.freebsd.org/~gonzo/mips2/libpam3.diff Drop > NO_STATIC_MODULES since it's a default and add PAM_STATIC_MODULES to > request static modules build. IMHO, since the #ifdef'ed part in openpam.h mentions "gcc static linking", it would probably be nice to keep the __GNUC__ part in -#if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES) +#if defined(PAM_STATIC_MODULES) /* gcc, static linking */ and write it as -#if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES) +#if defined(__GNUC__) && defined(PAM_STATIC_MODULES) /* gcc, static linking */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?874p5rt4gz.fsf>