Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 03 Jul 2005 01:10:59 -0000
From:      "Jacques A. Vidrine" <nectar@FreeBSD.org>
To:        Andrey Chernov <ache@nagual.pp.ru>, Poul-Henning Kamp <phk@FreeBSD.ORG>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/kern sys_generic.c
Message-ID:  <20050125153729.GF5662@lum.celabo.org>
In-Reply-To: <20050125094226.GA28188@nagual.pp.ru>
References:  <200501250915.j0P9FW80032279@repoman.freebsd.org> <20050125094226.GA28188@nagual.pp.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 25, 2005 at 12:42:26PM +0300, Andrey Chernov wrote:
> On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote:
> >     sys/kern             sys_generic.c 
> >   Log:
> >   Previously a read of zero bytes got handled in devfs:vop_read() but I
> >   missed that when the vnode bypass was introduced.
> >   
> >   Deal with zero length transfers before we even get to fo_ops->fo_read().
> 
> Please back it out. Zero bytes read may affect atime, now not.

I do not think that a zero byte read should not affect atime.

,----[ IEEE Std 1003.1, 2004 Edition ]
| Upon successful completion, where nbyte is greater than 0, read()
| shall mark for update the st_atime field of the file, and shall return
| the number of bytes read.
`----

Cheers,
-- 
Jacques A Vidrine / NTT/Verio
nectar@celabo.org / jvidrine@verio.net / nectar@FreeBSD.org




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050125153729.GF5662>